Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][TEST] Do not merge. Test uom_category_active CI #1754

Closed
wants to merge 1 commit into from

Conversation

legalsylvain
Copy link
Contributor

Hi. This is a Test PR.

Context : I have a weird error in my PR : #1657

The error is

2024-10-31 13:13:22,733 485 ERROR odoo odoo.addons.uom_category_active.tests.test_uom_category_active: FAIL: TestProductCategoryActive.test_archive_reference_uom
Traceback (most recent call last):
  File "/__w/product-attribute/product-attribute/uom_category_active/tests/test_uom_category_active.py", line 33, in test_archive_reference_uom
    with self.assertRaises(UserError):
  File "/usr/lib/python3.10/contextlib.py", line 142, in __exit__
    next(self.gen)
  File "/opt/odoo/odoo/tests/common.py", line 382, in _assertRaises
    with ExitStack() as inner:
  File "/usr/lib/python3.10/contextlib.py", line 576, in __exit__
    raise exc_details[1]
  File "/usr/lib/python3.10/contextlib.py", line 561, in __exit__
    if cb(*exc_details):
AssertionError: UserError not raised

@legalsylvain
Copy link
Contributor Author

Hi @angelmoya. The module you proposed here #1337 has the test failing. Could you take a look ?

thanks !

@simahawk
Copy link
Contributor

simahawk commented Nov 6, 2024

IMO we should comment the test and create a specific issue. That test looks incomplete as is not clear what is testing.

simahawk added a commit to camptocamp/product-attribute that referenced this pull request Nov 6, 2024
@simahawk
Copy link
Contributor

simahawk commented Nov 6, 2024

Commented here #1761
Issue opened here #1762

@simahawk
Copy link
Contributor

simahawk commented Nov 6, 2024

Ah sorry @legalsylvain I didn't see you reworked it here #1760, my bad 😓 I'll review that, sorry for the noise!

@simahawk
Copy link
Contributor

simahawk commented Nov 6, 2024

#1760 is getting merged

@simahawk simahawk closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants