[16.0][MIG] product_main_supplierinfo #1353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no specific record are found by the first filter. The Odoo default method will return all active supplier info. Which will include also supplier info record related to other specific variant. With this change if some supplier info related to the product variant exist, they will be returned instead. Also add a sort on the price to have the same behaviour than on a purchase order line for the price selected.
aliciagaarzo
force-pushed
the
16.0-mig-product_main_supplierinfo
branch
from
b3faf47 to
1daac05
Compare
sebalix
requested changes
Sep 7, 2023
| "summary": "Display the main vendor of a product.", | ||
| "website": "https://github.com/OCA/product-attribute", | ||
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "maintainers": ["sebalix"], | ||
| "development_status": "Beta", | ||
| "license": "AGPL-3", | ||
| "category": "Product", | ||
| "depends": ["product", "purchase"], | ||
| "depends": ["product", "purchase", "sale"], |
There was a problem hiding this comment.
@aliciagaarzo can you explain why we need sale as dependency starting from 16.0?
We should be able to install only purchase and manage our suppliers without sale, there is probably something to fix if we need it now.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
bofiltd
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of product_main_supplierinfo module to version 16