Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] product_main_supplierinfo #1353

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions product_main_supplierinfo/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
{
"name": "Product Main Vendor",
"version": "14.0.1.0.1",
"version": "16.0.1.0.0",
"summary": "Display the main vendor of a product.",
"website": "https://github.com/OCA/product-attribute",
"author": "Camptocamp, Odoo Community Association (OCA)",
"maintainers": ["sebalix"],
"development_status": "Beta",
"license": "AGPL-3",
"category": "Product",
"depends": ["product", "purchase"],
"depends": ["product", "purchase", "sale"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliciagaarzo can you explain why we need sale as dependency starting from 16.0?
We should be able to install only purchase and manage our suppliers without sale, there is probably something to fix if we need it now.

"data": ["views/product_product.xml"],
"auto_install": False,
"installable": True,
Expand Down
2 changes: 1 addition & 1 deletion product_main_supplierinfo/models/product_product.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class ProductProduct(models.Model):
)

@api.depends(
"seller_ids.name.active",
"seller_ids.partner_id.active",
"seller_ids.sequence",
"seller_ids.min_qty",
"seller_ids.price",
Expand Down
4 changes: 2 additions & 2 deletions product_main_supplierinfo/tests/test_product_main_supplier.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)

from odoo import fields
from odoo.tests.common import SavepointCase
from odoo.tests.common import TransactionCase


class TestProductMainSupplierInfo(SavepointCase):
class TestProductMainSupplierInfo(TransactionCase):
@classmethod
def setUpClass(cls):
super(TestProductMainSupplierInfo, cls).setUpClass()
Expand Down
6 changes: 6 additions & 0 deletions setup/product_main_supplierinfo/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setuptools

setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)