Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_product_pack: Migration to 17.0 #156

Merged
merged 67 commits into from
May 14, 2024
Merged

[17.0][MIG] sale_product_pack: Migration to 17.0 #156

merged 67 commits into from
May 14, 2024

Conversation

bruno-zanotti
Copy link
Contributor

No description provided.

@bruno-zanotti bruno-zanotti mentioned this pull request Dec 5, 2023
Open
4 tasks
@bruno-zanotti bruno-zanotti force-pushed the 17.0-mig-sale_product_pack branch 2 times, most recently from f3e380f to 8826185 Compare December 5, 2023 16:29
@bruno-zanotti bruno-zanotti marked this pull request as ready for review December 18, 2023 21:07
@bruno-zanotti bruno-zanotti force-pushed the 17.0-mig-sale_product_pack branch from 8826185 to ad71824 Compare December 18, 2023 21:12
@jappi00
Copy link

jappi00 commented Jan 4, 2024

Functional: LGTM

FrancoMaxime
FrancoMaxime reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bruno-zanotti, Why did you add the migration of product_pack inside this PR instead of using a temporary reference to your other PR? See Documentation

@bruno-zanotti
Copy link
Contributor Author

@FrancoMaxime because I didn't know about that 😅 let me fix it

@bruno-zanotti bruno-zanotti force-pushed the 17.0-mig-sale_product_pack branch 2 times, most recently from 0776a91 to 979af3d Compare January 9, 2024 15:31
@bruno-zanotti bruno-zanotti force-pushed the 17.0-mig-sale_product_pack branch from 979af3d to 65465c4 Compare April 22, 2024 14:23
@bruno-zanotti
Copy link
Contributor Author

Hey @pedrobaeza @FrancoMaxime, now that product_pack is merged we can merge this one too, same with #157

@pedrobaeza
Copy link
Member

/ocabot migration sale_product_pack

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 22, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza changed the title [MIG] sale_product_pack: Migration to 17.0 [17.0][MIG] sale_product_pack: Migration to 17.0 May 14, 2024
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-156-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 14, 2024
@OCA-git-bot
Merge PR #156 into 17.0
c37dc37 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-156-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Please rebase and fix pre-commit:

sale_product_pack/models/sale_order_line.py:35:89: E501 Line too long (92 > 88)

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-156-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

oca-transbot and others added 22 commits May 14, 2024 09:43
@oca-transbot @bruno-zanotti
Update translation files
aac4dff 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-14.0/product-pack-14.0-sale_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-14-0/product-pack-14-0-sale_product_pack/
@cvinh @bruno-zanotti
[IMP] Improve tests for sale_product_pack
1ef411e
@OCA-git-bot @bruno-zanotti
sale_product_pack 14.0.1.1.1
02253c4
@nicomacr @bruno-zanotti
[MIG] sale_product_pack: Migration to 15.0
906c271
@bruno-zanotti
[UPD] Update sale_product_pack.pot
22c462d
@OCA-git-bot @bruno-zanotti
[UPD] README.rst
83b933a
@FrancoMaxime @bruno-zanotti
[MIG] sale_product_pack: Migration to 16.0
b0de306
@FrancoMaxime @bruno-zanotti
[FIX] sale_product_pack - Recomputes correctly the price of product_p…
a2517dd 
…ack after updating pricelist
@augusto-weiss @bruno-zanotti
[FIX] sale_product_pack: fix error when creating Down Payment
af1a783
@augusto-weiss @bruno-zanotti
[FIX] sale_product_pack: for compatibility with sale_product_pack_ass…
d068f8d 
…isted
@bruno-zanotti
[UPD] Update sale_product_pack.pot
e01b8f9
@OCA-git-bot @bruno-zanotti
[UPD] README.rst
e6635ab
@weblate @bruno-zanotti
Update translation files
ab726df 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-16.0/product-pack-16.0-sale_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-sale_product_pack/
@OCA-git-bot @bruno-zanotti
[UPD] README.rst
a236690
@Ivorra78 @bruno-zanotti
Translated using Weblate (Spanish)
4108911 
Currently translated at 100.0% (21 of 21 strings)

Translation: product-pack-16.0/product-pack-16.0-sale_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-sale_product_pack/es/
@mymage @bruno-zanotti
Added translation using Weblate (Italian)
ad07bd3
@mymage @bruno-zanotti
Translated using Weblate (Italian)
1f6f976 
Currently translated at 100.0% (21 of 21 strings)

Translation: product-pack-16.0/product-pack-16.0-sale_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-sale_product_pack/it/
@mymage @bruno-zanotti
Translated using Weblate (Italian)
6f5a9e3 
Currently translated at 100.0% (21 of 21 strings)

Translation: product-pack-16.0/product-pack-16.0-sale_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-sale_product_pack/it/
@ALopez-Adhoc @bruno-zanotti
[IMP] sale_product_pack: add sale demo for each type of pack
73670db
@OCA-git-bot @bruno-zanotti
[BOT] post-merge updates
aa2aab9
@bruno-zanotti
[IMP] sale_product_pack: pre-commit execution
71a6a14
@bruno-zanotti
[MIG] sale_product_pack: Migration to 17.0
34df5c0
@bruno-zanotti bruno-zanotti force-pushed the 17.0-mig-sale_product_pack branch from 65465c4 to 34df5c0 Compare May 14, 2024 12:47
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-156-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e5e8a47 into OCA:17.0 May 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e5a7276. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoMaxime FrancoMaxime FrancoMaxime left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@Abranes Abranes Abranes approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.