[17.0][MIG] stock_product_pack: Migration to 17.0 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-zanotti
force-pushed
the
17.0-mig-stock_product_pack
branch
from
67d8da1 to
5198f7b
Compare
|
Functional: LGTM |
FrancoMaxime
reviewed
Jan 9, 2024
| @@ -13,10 +13,10 @@ class ProductProduct(models.Model): | |||
| def _compute_quantities_dict( | |||
| self, lot_id, owner_id, package_id, from_date=False, to_date=False | |||
| ): | |||
| res = super()._compute_quantities_dict( | |||
| packs = self.filtered("pack_ok") | |||
There was a problem hiding this comment.
I think we could improve this, because self.filtered will browse all items, then the self - packs will browse again all items to make the computation. I think you can do the split inside this method to avoid to browse 2 times the elements.
Why do you think about it?
There was a problem hiding this comment.
The prefetch is shared, so not very big problem. There's just a new set operation.
bruno-zanotti
force-pushed
the
17.0-mig-stock_product_pack
branch
from
5198f7b to
c2ae6e4
Compare
bruno-zanotti
force-pushed
the
17.0-mig-stock_product_pack
branch
from
c2ae6e4 to
8ac882b
Compare
bruno-zanotti
force-pushed
the
17.0-mig-stock_product_pack
branch
from
8ac882b to
0f1a25f
Compare
bruno-zanotti
force-pushed
the
17.0-mig-stock_product_pack
branch
from
0f1a25f to
ffcbfed
Compare
|
@OCA/tools-mainteiners Merge please! Thz |
|
@OCA-git-bot Merge please! Thx |
|
/ocabot migration stock_product_pack There isn't any review yet. |
pedrobaeza
changed the title
rousseldenis
reviewed
Sep 6, 2024
| @@ -27,6 +27,7 @@ def _compute_quantities_dict( | |||
| for subproduct in subproducts: | |||
| subproduct_stock = subproduct.product_id | |||
| sub_qty = subproduct.quantity | |||
| # import pdb;pdb.set_trace() | |||
There was a problem hiding this comment.
Could you remove this ?
This was referenced Oct 30, 2024
|
created this PR to include last changes request so that it could get merged: |
Currently translated at 100.0% (1 of 1 strings) Translation: product-pack-12.0/product-pack-12.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/pt/
Currently translated at 100.0% (1 of 1 strings) Translation: product-pack-12.0/product-pack-12.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/fr/
…ines. It seems to me that it would be if a user has the maximum stock permission, can edit the lines of packs, as well as a maximum sales permission.
…s if the product is storable.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-13.0/product-pack-13.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-stock_product_pack/
In v13 Odoo sets the stock at zero for products that are not services. This commit will keep the stock of the services if they are packs, to remain the functionality of the lasts versions.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/
Currently translated at 100.0% (5 of 5 strings) Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/es/
Currently translated at 100.0% (5 of 5 strings) Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
Currently translated at 100.0% (5 of 5 strings) Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
bruno-zanotti
force-pushed
the
17.0-mig-stock_product_pack
branch
from
ffcbfed to
75905dc
Compare
@FrancoMaxime @natuan9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.