Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] purchase_order_line_sequence #1060

Merged
merged 22 commits into from
Jul 4, 2021

Conversation

cjallais
Copy link
Contributor

@cjallais cjallais commented Jan 7, 2021

Migrate from v12 to v14

Dependency

SerpentCS and others added 19 commits January 7, 2021 12:14
If the creation of purchase order lines is made with form view rather than tree view then the module misbehaves, ie, creates a line with sequence 9999. This fixes that without breaking the tree view usage. It also makes sure that the sequence is kept when duplicating a purchase order, which makes more sense. It seems that this was a typo/bug on the original module which was not manifestating when using tree view but becomes clear when allowing editing of the purchase order line with form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Currently translated at 88.9% (8 of 9 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/fr/
@kittiu
Copy link
Member

kittiu commented Jan 11, 2021

Thank you for helping this migration. As for the name of the PR, if you could change it to searchable name, i.e, purchase_order_line_sequence, that would be awesome. Sometime people redo it because they don't know it was being done. Thanks!

@kittiu
Copy link
Member

kittiu commented Jan 11, 2021

Please follow this guide line https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0#technical-method-to-migrate-a-module-from-130-to-140-branch
to have 2 commits, one for pre-commit, and another for the migrate as specified there. It will help reviewer in reviewing the change.

@cjallais cjallais changed the title 14.0 purchase order line sequence 14.0 purchase_order_line_sequence Feb 3, 2021
@cjallais cjallais force-pushed the 14.0-purchase_order_line_sequence branch from 07464d0 to effa2dc Compare February 3, 2021 19:06
@cjallais cjallais changed the title 14.0 purchase_order_line_sequence [14.0][MIG] purchase_order_line_sequence Feb 3, 2021
@dsolanki-initos
Copy link
Contributor

@cjallais Is it possible to resolve the failed checks?

@cjallais
Copy link
Contributor Author

cjallais commented Mar 11, 2021 via email

@dsolanki-initos
Copy link
Contributor

@cjallais To resolve this error please add the repo "stock-logistics-workflow" in the oca_dependencies.txt file.

@cjallais cjallais force-pushed the 14.0-purchase_order_line_sequence branch from effa2dc to 965698e Compare March 12, 2021 16:45
@dsolanki-initos
Copy link
Contributor

Hi @cjallais ,
It seems that the depended module PR OCA/stock-logistics-workflow#768 is ready to merge. Can you please ask the PSC team member to get that PR merge? So the checks will be passed for this PR.

@dsolanki-initos
Copy link
Contributor

Hi @cjallais
Can you please request the PSC team member to merge the depended PR as it is approved. So we can get this PR merged soon.

@dsolanki-initos
Copy link
Contributor

Hi @cjallais if possible please resolve the conflicts.

@@ -12,6 +12,7 @@
"author": "Camptocamp, "
"Eficent, "
"Serpent CS, "
"ArcheTI, "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as contributors not as author

@dsolanki-initos
Copy link
Contributor

@cjallais please resolve the conflicts

@cjallais cjallais force-pushed the 14.0-purchase_order_line_sequence branch from 965698e to 0d84b1b Compare April 23, 2021 19:12
@dsolanki-initos
Copy link
Contributor

@cjallais It would be great if you can resolve conflicts.

@cjallais cjallais force-pushed the 14.0-purchase_order_line_sequence branch from e6c8ad5 to 0d84b1b Compare May 4, 2021 12:21
@dsolanki-initos
Copy link
Contributor

It would be nice if we could merge this PR.

@dsolanki-initos
Copy link
Contributor

It would be nice if we could merge the PR.

Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dsolanki-initos
Copy link
Contributor

It would be great if we could get the reviews here.

1 similar comment
@dsolanki-initos
Copy link
Contributor

It would be great if we could get the reviews here.

@dsolanki-initos
Copy link
Contributor

It would be great if we could get the reviews and merge the PR soon

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dsolanki-initos
Copy link
Contributor

It would be ncie if the maintainers merge this PR

@dreispt
Copy link
Member

dreispt commented Jul 3, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1060-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 3, 2021
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1060-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b55abe5 into OCA:14.0 Jul 4, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c6fd4d9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.