Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] stock_picking_line_sequence #768

Merged
merged 23 commits into from
May 1, 2021
Merged

[14.0][MIG] stock_picking_line_sequence #768

merged 23 commits into from
May 1, 2021

Conversation

cjallais
Copy link
Contributor

@cjallais cjallais commented Jan 7, 2021

Migration from v12.0 to 14.0 of stock_picking_line_sequence

serpentcs-dev1 and others added 21 commits January 7, 2021 11:40
@serpentcs-dev1 @cjallais
[REM] redundant code
132996b
@serpentcs-dev1 @cjallais
[MIG] stock_picking_line_sequence v10
d57ded8
@serpentcs-dev1 @cjallais
[IMP] docstring
5d25b7e
@oca-transbot @cjallais
OCA Transbot updated translations from Transifex
f4d2e8b 
OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
@oca-travis @cjallais
[UPD] Update stock_picking_line_sequence.pot
73c2304
@AdriaGForgeFlow @cjallais
[10.0][FIX] stock_picking_line_sequence module
ceb50db
@bjeficent @cjallais
[MIG] stock_picking_line_sequence migrated to version 12.0
b92822d
@OCA-git-bot @cjallais
[ADD] icon.png
9a1831c
@oca-travis @cjallais
[UPD] Update stock_picking_line_sequence.pot
29fa762
@oca-transbot @cjallais
Update translation files
ef36578 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/
@OCA-git-bot @cjallais
[UPD] README.rst
98d2ae2
@AaronHForgeFlow @cjallais
[FIX]keep original sequence when creating backorders
43fa240
@MiquelRForgeFlow @cjallais
[IMP] Add sequence to delivery slip report
2b706c9
@oca-travis @cjallais
[UPD] Update stock_picking_line_sequence.pot
1c54a8f
@OCA-git-bot @cjallais
stock_picking_line_sequence 12.0.1.1.0
273805e
@oca-transbot @cjallais
Update translation files
d63c0d4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/
@sergiocorato @cjallais
[FIX] stock picking line unuseful and very slow update
c8586ee
@OCA-git-bot @cjallais
stock_picking_line_sequence 12.0.1.1.1
3e49563
@fcolus @cjallais
Translated using Weblate (Portuguese (Brazil))
5bb3bb0 
Currently translated at 100.0% (7 of 7 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/pt_BR/
@sysadminmatmoz @cjallais
Translated using Weblate (Slovenian)
6cd307e 
Currently translated at 100.0% (7 of 7 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/sl/
@oca-transbot @cjallais
Update translation files
15a325b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/
@rousseldenis rousseldenis added this to the 14.0 milestone Jan 8, 2021
@rousseldenis rousseldenis mentioned this pull request Jan 8, 2021
Open
57 tasks
@kittiu kittiu mentioned this pull request Jan 11, 2021
Merged
1 task
@kittiu
Copy link
Member

kittiu commented Jan 11, 2021 •
edited
Loading

This module is required by OCA/purchase-workflow#1060
Similar to that, can you,

  • Set the name of this PR for easy search.
  • Follow the guideline, and make 2 commits to ease reviewer.

Thank you :)

@cjallais cjallais changed the title 14.0 stock picking line sequence [14.0][MIG] stock_picking_line_sequence Feb 3, 2021
@cjallais cjallais force-pushed the 14.0-stock_picking_line_sequence branch from 73ec4c7 to 63f1b62 Compare February 3, 2021 18:50
rousseldenis
rousseldenis reviewed Feb 4, 2021
View reviewed changes
stock_picking_line_sequence/models/stock.py
class StockMoveLine(models.Model):
_inherit = "stock.move.line"

def _get_aggregated_product_quantities(self, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for this part ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. See last function in test file.

@cjallais cjallais force-pushed the 14.0-stock_picking_line_sequence branch from 63f1b62 to 63af37b Compare February 4, 2021 16:26
@cjallais cjallais force-pushed the 14.0-stock_picking_line_sequence branch from 63af37b to 189e218 Compare February 4, 2021 16:29
@bodedra
Copy link
Member

bodedra commented Feb 5, 2021

I have tested it on runbot with Sale module.

I have created a order with 4 order lines and confirm it. Verify DO, sequence for all stock moves are 9,999

Screenshot from 2021-02-05 10-42-52

Is this expected?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cjallais
Copy link
Contributor Author

cjallais commented Apr 8, 2021

Hello,

Is there someone here that can merge this? It's ready to merge. Need it to be able to merge a dependant module in another repository.
Thanks
Cécile Jallais

@dreispt
Copy link
Member

dreispt commented May 1, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-768-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1b4ed88 into OCA:14.0 May 1, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1ce3044. Thanks a lot for contributing to OCA. ❤️

@rousseldenis
Copy link
Contributor

@dreispt a question was on suspend...

@jesus01x jesus01x mentioned this pull request May 5, 2021
Merged
@dreispt
Copy link
Member

dreispt commented May 6, 2021

Hmm, last comment is a request to merge.
Can you open an Issue with the pending question please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.