Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] purchase_order_line_sequence: Migration to 16.0 #1961

Merged
merged 34 commits into from
Dec 3, 2024
Merged

[16.0][MIG] purchase_order_line_sequence: Migration to 16.0 #1961

merged 34 commits into from
Dec 3, 2024

Conversation

AungKoKoLin1997
Copy link
Contributor

Standard migration base on #1933
Depends on: OCA/stock-logistics-workflow#1316

@qrtl

@gbrito
Copy link

gbrito commented Aug 4, 2023

@AungKoKoLin1997
You can fix tests here by including a pending PR by adding a separated commit w/ this change in tests-requirements.txt:

odoo-addon-stock_picking_line_sequence @ git+https://github.com/OCA/stock-logistics-workflow@refs/pull/1316/head#subdirectory=setup/stock_picking_line_sequence

@LoisRForgeFlow
Copy link
Contributor

#1933 got merged, can you ensure that you have the lastest version included here?

@AungKoKoLin1997
Copy link
Contributor Author

#1933 got merged, can you ensure that you have the lastest version included here?

This PR is included the latest version of #1933

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from d5c809e to b83339b Compare October 13, 2023 07:38
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from b83339b to e258384 Compare December 1, 2023 07:16
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from e258384 to 52cab2c Compare January 25, 2024 07:26
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 52cab2c to 4cb5f87 Compare April 18, 2024 02:41
@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Apr 18, 2024
Open
53 tasks
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 4cb5f87 to 8c170a3 Compare June 10, 2024 09:52
@FreezeS
Copy link

FreezeS commented Jul 8, 2024

Hi guys, is there a problem with this PR? I see it's been almost a year and it's not merged.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 8c170a3 to 2a64bce Compare July 31, 2024 16:01
@StefanRijnhart
Copy link
Member

Looks like we need #1990 in here as well.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from 4dbde55 to cb5c4b7 Compare September 23, 2024 14:37
@AungKoKoLin1997
Copy link
Contributor Author

Looks like we need #1990 in here as well.

I added the new commit.

StefanRijnhart
StefanRijnhart approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@StefanRijnhart StefanRijnhart mentioned this pull request Sep 23, 2024
Open
@StefanRijnhart
Copy link
Member

StefanRijnhart commented Sep 23, 2024 •
edited
Loading

FYI I based my v17 migration on this PR. #2414

SerpentCS and others added 13 commits November 15, 2024 09:25
@SerpentCS @AungKoKoLin1997
[IMP] renamed the module name.
98ff4cc
@SerpentCS @AungKoKoLin1997
[ADD] added dependencies and sequences
04b202d
@serpentcs-dev1 @AungKoKoLin1997
[IMP] test cases
4010328
@serpentcs-dev1 @AungKoKoLin1997
[ADD] purchase_order_line_sequence v10
4fd6a11
@jpoa @AungKoKoLin1997
[ADD] Missing dependency
90efffc
@jpoa @AungKoKoLin1997
[FIX] Bug in the logic of the module
08c52f8 
If the creation of purchase order lines is made with form view rather than tree view then the module misbehaves, ie, creates a line with sequence 9999. This fixes that without breaking the tree view usage. It also makes sure that the sequence is kept when duplicating a purchase order, which makes more sense. It seems that this was a typo/bug on the original module which was not manifestating when using tree view but becomes clear when allowing editing of the purchase order line with form view.
@MiquelRForgeFlow @AungKoKoLin1997
[FIX] Assure sequence of stock moves are the same as of po lines
8538b9f
@MiquelRForgeFlow @AungKoKoLin1997
[FIX] Correct a test. Products are in purchase_method 'receive'
d363ba5
@oca-travis @AungKoKoLin1997
[UPD] Update purchase_order_line_sequence.pot
d88c2f6
@MiquelRForgeFlow @AungKoKoLin1997
[FIX] Make module compatible with other reporting modules
7aab262
@bjeficent @AungKoKoLin1997
[MIG] purchase_order_line_sequence to version 12
5ac231c
@oca-travis @AungKoKoLin1997
[UPD] Update purchase_order_line_sequence.pot
d4304db
@OCA-git-bot @AungKoKoLin1997
[UPD] README.rst
06a1ad2
cjallais and others added 14 commits November 15, 2024 09:25
@cjallais @AungKoKoLin1997
[MIG] purchase_order_line_sequence: Migration to 14.0
6166e5b
@oca-travis @AungKoKoLin1997
[UPD] Update purchase_order_line_sequence.pot
597f3c0
@OCA-git-bot @AungKoKoLin1997
[UPD] README.rst
50529e0
@MiquelRForgeFlow @AungKoKoLin1997
[IMP] purchase_order_line_sequence: delete unused file
5be7cf1
@manengel @AungKoKoLin1997
Added translation using Weblate (German)
044ddcc
@rousseldenis @AungKoKoLin1997
[REM] purchase_order_line_sequence: Not needed anymore
fc7b29e 
After odoo/odoo@49b143e

the sequence is correctly transmitted from purchase line to invoice line.
@mt-software-de @AungKoKoLin1997
[FIX] Adding tags to unittests for purchase_deposit and purchase_orde…
ffd8a5a 
…r_line_sequence
@JHernandezConinpe @AungKoKoLin1997
Added translation using Weblate (Spanish)
5fd2fa5
@JHernandezConinpe @AungKoKoLin1997
Translated using Weblate (Spanish)
08dced6 
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_line_sequence/es/
@OriolMForgeFlow @AungKoKoLin1997
[IMP] purchase_order_line_sequence: use correct sequence in moves whe…
95d3f7f 
…n section or notes in purchase order
@AungKoKoLin1997
[IMP] purchase_order_line_sequence: pre-commit stuff
2d13609
@OriolMForgeFlow @AungKoKoLin1997
[IMP] purchase_order_line_sequence: module refactor, new sequence fie…
8917980 
…lds for orders and invoices
@AungKoKoLin1997
[MIG] purchase_order_line_sequence: Migration to 16.0
1160c11
@SergiCForgeFlow @AungKoKoLin1997
[IMP] purchase_order_line_sequence: Show only PO related sequence in …
6a6ef4f 
…Vendor Bills
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-purchase_order_line_sequence branch from cb5c4b7 to 6a6ef4f Compare November 15, 2024 09:25
@AungKoKoLin1997
Copy link
Contributor Author

@oca/purchase-workflow-maintainers
Can you please view this PR?

@AungKoKoLin1997
Copy link
Contributor Author

@FreezeS Can you please review?

Christian-RB
Christian-RB approved these changes Nov 15, 2024
View reviewed changes
Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 3, 2024
@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1961-by-StefanRijnhart-bump-nobump, awaiting test results.

@StefanRijnhart
Copy link
Member

/ocabot migration purchase_order_line_sequence

@OCA-git-bot OCA-git-bot merged commit 51f0cbf into OCA:16.0 Dec 3, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e668749. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christian-RB Christian-RB Christian-RB approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.