Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_picking_line_sequence #1316

Merged
merged 35 commits into from
Oct 13, 2023
Merged

[16.0][MIG] stock_picking_line_sequence #1316

merged 35 commits into from
Oct 13, 2023

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Jun 23, 2023 •
edited
Loading

Standard migration
stock_picking_line_sequence

@bosd bosd changed the title 16.0 mig stock picking line sequence [16.0][MIG] stock_picking_line_sequence Jun 23, 2023
@bosd bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch from 84f8f16 to 7a88b45 Compare June 23, 2023 17:43
@bosd bosd marked this pull request as ready for review June 23, 2023 17:48
@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_line_sequence

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 7, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 7, 2023
Open
70 tasks
rousseldenis
rousseldenis approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Aug 1, 2023
Merged
AungKoKoLin1997
AungKoKoLin1997 reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is not working as expected.
When we create transfer and then add new product line, the sequence is 1 for first line. But after clicked save button, it changes to 2.

This is before we save.

Screen Shot 2023-08-02 at 08 24 07

This is after we saved.

Screen Shot 2023-08-02 at 08 24 19

@bosd bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch from 28a8d75 to 4f9b3ed Compare September 23, 2023 15:32
@bosd
Copy link
Contributor Author

bosd commented Sep 29, 2023

Can we get a merge? 🙏

@rousseldenis
Copy link
Contributor

@bosd Could you amend your last commit message to add the module name and a better summary ?

image

Thanks

@bosd bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch 2 times, most recently from e26905c to a3c7969 Compare October 2, 2023 16:27
@bosd
Copy link
Contributor Author

bosd commented Oct 2, 2023

tests are broken. It seems we need this now.
#1329

@bosd
Copy link
Contributor Author

bosd commented Oct 3, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @bosd you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

sysadminmatmoz and others added 16 commits October 7, 2023 14:05
@sysadminmatmoz @bosd
Translated using Weblate (Slovenian)
906c540 
Currently translated at 100.0% (7 of 7 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/sl/
@oca-transbot @bosd
Update translation files
2787fc0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/
@cjallais @bosd
[IMP] stock_picking_line_sequence: black, isort, prettier
c250547
@cjallais @bosd
[MIG] stock_picking_line_sequence: Migration to 14.0
b27eb57
@oca-travis @bosd
[UPD] Update stock_picking_line_sequence.pot
b66d770
@OCA-git-bot @bosd
[UPD] README.rst
a6e6cf1
@MiquelRForgeFlow @bosd
[UPD] contributors: Eficent -> ForgeFlow
4951fc8
@OCA-git-bot @bosd
[UPD] README.rst
4b834c8
@slominchar @bosd
[IMP] stock_picking_line_sequence: black, isort, prettier
a93a8ab
@slominchar @bosd
[MIG] stock_picking_line_sequence: Migration to 15.0
c84ecdb
@bosd
[UPD] Update stock_picking_line_sequence.pot
f0d5b83
@OCA-git-bot @bosd
[UPD] README.rst
722bef6
@francesco-ooops @bosd
Translated using Weblate (Italian)
655ae13 
Currently translated at 28.5% (2 of 7 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_line_sequence/it/
@bosd
[IMP] stock_picking_line_sequence: pre-commit execution
b426169
@bosd
[MIG] stock_picking_line_sequence: Migration to 16.0
f5ae154
@bosd
[FIX] stock_picking_line_sequence: sequence number
38e8e2a 
only update the sequence number when the line number is an integer.
@bosd bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch from c306147 to 38e8e2a Compare October 7, 2023 12:05
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997
Copy link
Contributor

@rousseldenis Can we get this PR merged?

rousseldenis
rousseldenis reviewed Oct 13, 2023
View reviewed changes
stock_picking_line_sequence/models/stock.py
line.sequence = current_sequence
current_sequence += 1
# Check if the record ID is an integer (real ID) or a string (virtual ID)
if isinstance(line.id, int):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosd FYI, usually, we use NewId class instead.

So:

if not isinstance(line.id, NewId):

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1316-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0cf2b42 into OCA:16.0 Oct 13, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ef182a3. Thanks a lot for contributing to OCA. ❤️

@bosd
Copy link
Contributor Author

bosd commented Oct 13, 2023

@CasVissers-360ERP It's merged 😉

@bosd bosd deleted the 16.0-mig-stock_picking_line_sequence branch October 17, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.