Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] Migrate report_xlsx to 16.0 #654

Closed
wants to merge 68 commits into from
Closed

[MIG] Migrate report_xlsx to 16.0 #654

wants to merge 68 commits into from

Conversation

adrienpeiffer
Copy link
Contributor

No description provided.

adrienpeiffer and others added 30 commits October 4, 2022 09:51
@adrienpeiffer
[CHG] Rename base_report_xlsx to report_xlsx and add xlsx report type…
fbbda3b 
… in selection
@sebalix @adrienpeiffer
[IMP] report_xlsx - Pass the report instance as well as ids of record…
0bd5c17 
…s to print to the 'create_xlsx_report' method + Instanciate the parser and make it available for the 'generate_xlsx_report' method
@adrienpeiffer
[MIG] Migration of report_xlsx to 10.0 (OCA#76)
7186cb1
@sbidoul @adrienpeiffer
[10.0] report_xlsx: Allow to define options for workbook creation (OC…
6f97e2c 
…A#98)

* Allow to define options for workbook creation
@oca-transbot @adrienpeiffer
OCA Transbot updated translations from Transifex
3676139
@etobella @adrienpeiffer
[MIG] report_xlsx: Migration to 11.0
c15105b
@oca-transbot @adrienpeiffer
OCA Transbot updated translations from Transifex
fec6d19
@naglis @adrienpeiffer
[IMP] report_fillpdf, report_xlsx, report_xml: Use content_dispositio…
4120c91 
…n helper
@oca-travis @adrienpeiffer
[UPD] Update report_xlsx.pot
9c66ea7
@gdgellatly @adrienpeiffer
Fix report_xlsx for printing from wizards
105f138
@ovnicraft @adrienpeiffer
[MIG] report_xlsx: Migration to 12.0
380e541 
* refactor: On new ActionManager override _makeReportUrls and triggerDownload to support XLSX format
* pass action to custom _downloadReportXLSX: Need action to get report data
* dict constructor to remove context lang
@pedrobaeza @adrienpeiffer
[IMP] report_xlsx: README by fragments
8063ef5
@oca-travis @adrienpeiffer
[UPD] Update report_xlsx.pot
452b4d4
@oca-transbot @adrienpeiffer
Update translation files
6bc4b20 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@rschnapka @adrienpeiffer
Translated using Weblate (German)
2b05d2b 
Currently translated at 88.2% (15 of 17 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/de/
@OCA-git-bot @adrienpeiffer
[UPD] README.rst
3bea1dd
@kittiu @adrienpeiffer
[12.0][IMP] report_xlsx, make sure print_report_name works
3ab6ba6
@pedrocs-exo @adrienpeiffer
Added translation using Weblate (Portuguese)
982b4f7
@pedrocs-exo @adrienpeiffer
Translated using Weblate (Portuguese)
5a90b1e 
Currently translated at 94.4% (17 of 18 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/pt/
@OCA-git-bot @adrienpeiffer
report_xlsx 12.0.1.0.1
239d99b
@schout-it @adrienpeiffer
[MIG] report_xlsx: Migration to 13.0
0ec0fd3
@schout-it @adrienpeiffer
[MIG][IMP][13.0] rebase to include new linters
6f3f977
@JoanSForgeFlow @adrienpeiffer
[FIX] report_xlsx: js
151bf5e
@oca-travis @adrienpeiffer
[UPD] Update report_xlsx.pot
3b6b709
@OCA-git-bot @adrienpeiffer
[UPD] README.rst
2e1a0e7
@oca-transbot @adrienpeiffer
Update translation files
2fcd854 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
@MiquelRForgeFlow @adrienpeiffer
[FIX] report_xlsx: rename a file
79e9124
@OCA-git-bot @adrienpeiffer
pre-commit update
bc1c027
@OCA-git-bot @adrienpeiffer
report_xlsx 13.0.1.0.1
dfeb043
@oca-transbot @adrienpeiffer
Update translation files
978c1c4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
@adrienpeiffer
Copy link
Contributor Author

/ocabot migration

@OCA-git-bot
Copy link
Contributor

Hi @adrienpeiffer. Your command failed:

Invalid options for command migration: .

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@adrienpeiffer
Copy link
Contributor Author

/ocabot migration report_xlsx

@OCA-git-bot
Copy link
Contributor

Sorry @adrienpeiffer you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@adrienpeiffer adrienpeiffer marked this pull request as draft October 4, 2022 07:56
@pedrobaeza
Copy link
Member

/ocabot migration report_xlsx

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 4, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 4, 2022
Open
15 tasks
@adrienpeiffer adrienpeiffer force-pushed the 16.0-mig-report_xlsx-ape branch 2 times, most recently from 554106a to cc58150 Compare October 4, 2022 09:29
@adrienpeiffer adrienpeiffer marked this pull request as ready for review October 4, 2022 09:30
@RodrigoBM RodrigoBM mentioned this pull request Oct 6, 2022
Merged
@adrienpeiffer adrienpeiffer force-pushed the 16.0-mig-report_xlsx-ape branch from cc58150 to 4cf8e60 Compare October 7, 2022 14:55
@adrienpeiffer adrienpeiffer force-pushed the 16.0-mig-report_xlsx-ape branch from 4cf8e60 to 083fc29 Compare October 7, 2022 14:57
@adrienpeiffer
Copy link
Contributor Author

Thanks @RodrigoBM

@adrienpeiffer adrienpeiffer mentioned this pull request Oct 11, 2022
Merged
9 tasks
@RodrigoBM RodrigoBM mentioned this pull request Oct 17, 2022
Merged
@ramiadavid ramiadavid mentioned this pull request Oct 28, 2022
Merged
@RodrigoBM
Copy link
Contributor

@adrienpeiffer the branch now has conflicts, can you chek it

JoanSForgeFlow
JoanSForgeFlow approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@JoanSForgeFlow JoanSForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Just needs a rebase and fix the conflict in requirements.txt

maq-adhoc
maq-adhoc reviewed Nov 22, 2022
View reviewed changes
report_xlsx/controllers/main.py
from odoo.tools import html_escape
from odoo.tools.safe_eval import safe_eval, time

from odoo.addons.web.controllers import report
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReportController should be imported like this

from odoo.addons.web.controllers.report import ReportController
class ReportController(ReportController):

because the controllers were reorganized

@maq-adhoc
Copy link

hi @adrienpeiffer . any news? if you don't have time, I can take it.

@RodrigoBM RodrigoBM mentioned this pull request Nov 30, 2022
Merged
@pedrobaeza
Copy link
Member

Superseded by #690

@pedrobaeza pedrobaeza closed this Dec 4, 2022
@sbidoul sbidoul deleted the 16.0-mig-report_xlsx-ape branch March 15, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maq-adhoc maq-adhoc maq-adhoc left review comments

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

@baimont baimont baimont approved these changes

@RodrigoBM RodrigoBM RodrigoBM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.