Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] report_xlsx: Migration to 16.0 #690

Merged
merged 68 commits into from
Dec 4, 2022
Merged

[16.0][MIG] report_xlsx: Migration to 16.0 #690

merged 68 commits into from
Dec 4, 2022

Conversation

RodrigoBM
Copy link
Contributor

pr alternative to the original pr #654

Add this comment #654 (review)

cc: @baimont @maq-adhoc @JoanSForgeFlow

adrienpeiffer and others added 30 commits November 30, 2022 12:46
@adrienpeiffer @RodrigoBM
[CHG] Rename base_report_xlsx to report_xlsx and add xlsx report type…
9e6dd0d 
… in selection
@sebalix @RodrigoBM
[IMP] report_xlsx - Pass the report instance as well as ids of record…
8d054ce 
…s to print to the 'create_xlsx_report' method + Instanciate the parser and make it available for the 'generate_xlsx_report' method
@adrienpeiffer @RodrigoBM
[MIG] Migration of report_xlsx to 10.0 (OCA#76)
76505f0
@sbidoul @RodrigoBM
[10.0] report_xlsx: Allow to define options for workbook creation (OC…
bdb9c43 
…A#98)

* Allow to define options for workbook creation
@oca-transbot @RodrigoBM
OCA Transbot updated translations from Transifex
804d9dc
@etobella @RodrigoBM
[MIG] report_xlsx: Migration to 11.0
30337ad
@oca-transbot @RodrigoBM
OCA Transbot updated translations from Transifex
f2e8622
@naglis @RodrigoBM
[IMP] report_fillpdf, report_xlsx, report_xml: Use content_dispositio…
98018a2 
…n helper
@oca-travis @RodrigoBM
[UPD] Update report_xlsx.pot
5fd955f
@gdgellatly @RodrigoBM
Fix report_xlsx for printing from wizards
095c321
@ovnicraft @RodrigoBM
[MIG] report_xlsx: Migration to 12.0
68767c3 
* refactor: On new ActionManager override _makeReportUrls and triggerDownload to support XLSX format
* pass action to custom _downloadReportXLSX: Need action to get report data
* dict constructor to remove context lang
@pedrobaeza @RodrigoBM
[IMP] report_xlsx: README by fragments
19f1058
@oca-travis @RodrigoBM
[UPD] Update report_xlsx.pot
a09e80a
@oca-transbot @RodrigoBM
Update translation files
f3a26d1 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@rschnapka @RodrigoBM
Translated using Weblate (German)
8bd65fb 
Currently translated at 88.2% (15 of 17 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/de/
@OCA-git-bot @RodrigoBM
[UPD] README.rst
7f8dd98
@kittiu @RodrigoBM
[12.0][IMP] report_xlsx, make sure print_report_name works
b43522b
@pedrocs-exo @RodrigoBM
Added translation using Weblate (Portuguese)
96bfdf3
@pedrocs-exo @RodrigoBM
Translated using Weblate (Portuguese)
367323a 
Currently translated at 94.4% (17 of 18 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/pt/
@OCA-git-bot @RodrigoBM
report_xlsx 12.0.1.0.1
1b49994
@schout-it @RodrigoBM
[MIG] report_xlsx: Migration to 13.0
fca87a5
@schout-it @RodrigoBM
[MIG][IMP][13.0] rebase to include new linters
54f46f6
@JoanSForgeFlow @RodrigoBM
[FIX] report_xlsx: js
fc887ce
@oca-travis @RodrigoBM
[UPD] Update report_xlsx.pot
4d8fef3
@OCA-git-bot @RodrigoBM
[UPD] README.rst
b948257
@oca-transbot @RodrigoBM
Update translation files
7d9df99 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
@MiquelRForgeFlow @RodrigoBM
[FIX] report_xlsx: rename a file
572f4b5
@OCA-git-bot @RodrigoBM
pre-commit update
720b1f0
@OCA-git-bot @RodrigoBM
report_xlsx 13.0.1.0.1
4c5a076
@oca-transbot @RodrigoBM
Update translation files
7051177 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
@RodrigoBM RodrigoBM changed the title 16.0 mig report xlsx ape [MIG] Migrate report_xlsx to 16.0 Nov 30, 2022
@RodrigoBM RodrigoBM mentioned this pull request Nov 30, 2022
Open
15 tasks
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-report_xlsx-ape branch from e85c6f1 to ca1d627 Compare December 2, 2022 17:10
@FernandoRomera
Copy link

@pedrobaeza Hi Pedro, can you merge this PR please?

@pedrobaeza pedrobaeza changed the title [MIG] Migrate report_xlsx to 16.0 [16.0][MIG] report_xlsx: Migration to 16.0 Dec 4, 2022
@pedrobaeza pedrobaeza mentioned this pull request Dec 4, 2022
Closed
@pedrobaeza
Copy link
Member

/ocabot migration report_xlsx
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 4, 2022
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-690-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2ca0859 into OCA:16.0 Dec 4, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3d36d80. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 16.0-mig-report_xlsx-ape branch December 4, 2022 16:04
@RodrigoBM RodrigoBM mentioned this pull request Dec 4, 2022
Merged
@alexis-via
Copy link
Contributor

I think we have a mistake here: in v16, the proto of report_download has changed it is now report_download(self, data, context=None, token=None)

https://github.com/odoo/odoo/blob/16.0/addons/web/controllers/report.py#L90

In report_xlsx, the proto is still report_download(self, data, context=None)
https://github.com/OCA/reporting-engine/blob/16.0/report_xlsx/controllers/main.py#L52

@alexis-via
Copy link
Contributor

Here is the kind of warning that you get due to this:

2022-12-12 19:51:28,599 62671 WARNING o6_test1 odoo.http: <function odoo.addons.report_xlsx.controllers.main.report_download> called ignoring args {'token'}

@pedrobaeza
Copy link
Member

Can you please fix it or @RodrigoBM?

@alexis-via
Copy link
Contributor

ok, I'll try to find time to make a PR

@alexis-via
Copy link
Contributor

PR here: #699

@FernandoRomera FernandoRomera mentioned this pull request Dec 29, 2022
Merged
9 tasks
@houzefa-abba houzefa-abba mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoRomera FernandoRomera FernandoRomera approved these changes

@AntoniRomera AntoniRomera AntoniRomera approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.