Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] report_xml #663

Merged
merged 50 commits into from
Oct 19, 2022
Merged

[16.0] [MIG] report_xml #663

merged 50 commits into from
Oct 19, 2022

Conversation

Du-ma
Copy link
Member

@Du-ma Du-ma commented Oct 18, 2022

Migration to 16.0.

Since odoo 16.0 is on a theme of making the thing run faster, thought some optimization changes could be made.

Slightly reworked the controller, renamed the file to more match the current odoo file structure.
Controller got reworked in a more logical manner, looked through illogical lines, and merged some if statements.

Cleaned up the .js file to make it more readable (offered a similar change in oca/server-tools/pull/2329)

Hard-coded in some variables that are related to xml report (if we print a xml report it won't become a pdf out of thin air).

Of course did all the necessary changes to make the thing run.

Also what the hell is that lang "mechanism"?
Like, I get it, but why?

Jairo Llopis and others added 30 commits October 17, 2022 15:41
Almost any XML must start with this. Let's make it easier.
Any report inheriting this AbstractModel can check its XML results
against any XSD.
Previous instructions were misleading
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xml
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xml/
OCA-git-bot and others added 12 commits October 17, 2022 15:41
* No longer need `with Environment.manage()`
* Assets are registered in manifest file now
* ReportController endpoints no longer take a `token` parameter
* The frontend ActionManager has been rewritten as an Owl service
Currently translated at 94.4% (17 of 18 strings)

Translation: reporting-engine-15.0/reporting-engine-15.0-report_xml
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_xml/ca/
@Du-ma Du-ma mentioned this pull request Oct 18, 2022
15 tasks
@Du-ma
Copy link
Member Author

Du-ma commented Oct 18, 2022

@etobella @aisopuro @ozono
Mind having a gander lads?

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

Worked like a charm 😄 Thanks for the refactoring of the JS

👍

@pedrobaeza
Copy link
Member

/ocabot migration report_xml

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 18, 2022
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@Du-ma
Copy link
Member Author

Du-ma commented Oct 19, 2022

@pedrobaeza
Hey, I think the command didn't work for some reason 😁

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-663-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5a734f2 into OCA:16.0 Oct 19, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5a67a6c. Thanks a lot for contributing to OCA. ❤️

@Du-ma Du-ma deleted the 16.0-mig-report_xml branch October 19, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.