-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] report_xml #663
Conversation
Almost any XML must start with this. Let's make it easier.
Any report inheriting this AbstractModel can check its XML results against any XSD.
Previous instructions were misleading
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xml/
* No longer need `with Environment.manage()` * Assets are registered in manifest file now * ReportController endpoints no longer take a `token` parameter * The frontend ActionManager has been rewritten as an Owl service
Currently translated at 94.4% (17 of 18 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_xml/ca/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review.
Worked like a charm 😄 Thanks for the refactoring of the JS
👍
/ocabot migration report_xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runboat
/ocabot merge nobump |
@pedrobaeza |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 5a67a6c. Thanks a lot for contributing to OCA. ❤️ |
Migration to
16.0
.Since odoo 16.0 is on a theme of making the thing run faster, thought some optimization changes could be made.
Slightly reworked the controller, renamed the file to more match the current odoo file structure.
Controller got reworked in a more logical manner, looked through illogical lines, and merged some if statements.
Cleaned up the
.js
file to make it more readable (offered a similar change in oca/server-tools/pull/2329)Hard-coded in some variables that are related to
xml
report (if we print a xml report it won't become a pdf out of thin air).Of course did all the necessary changes to make the thing run.
Also what the hell is that lang "mechanism"?
Like, I get it, but why?