[15.0][MIG] excel_import_export, excel_import_export_demo: migration #2329

Mantux11 · 2022-04-29T11:30:12Z

Migration to version 15.0. Changes by pre-commit and changes because of Odoo code changes.

Mantux11 · 2022-04-29T11:43:45Z

@kittiu Hey. Because of your migration to v13 and v14, I want some help from you. I think, you know how JS worked here and mostly all functionality what JS code does here. Personally, I don't know probably anything about JS, and I saw that Odoo deleted ActionManager and I suggest that everything was moved to services or somewhere else. So my questions are:

How JS code worked here, what was functionality of JS code, why it was used here?
Maybe you could suggest, where I could try to look to understand what is going on here? Maybe you know where everything was moved, what was changed and where I could insert these functions? Some files to look, classes and etc.

Thank you! 😉

kittiu · 2022-05-04T09:05:22Z

@Mantux11 you are wrong that I know what I was doing about JS 😆
I just try to imitate the work from other module, i..e, report_csv, report_xlsx.
Now, I saw this already migrated to v15 https://github.com/OCA/reporting-engine/blob/15.0/report_xlsx/static/src/js/report/action_manager_report.esm.js

:)

Mantux11 · 2022-05-05T13:23:37Z

@kittiu Thanks for your answer. I will try to change what it's needed to be changed. :D

kittiu · 2022-05-16T06:52:40Z

Not sure this is ready for review. Functional test couple of action without success.

Sales > Reporting > Partner List Report
Sales > Sales Order > Quotation / Order (.xlsx) ----> not in the print action yet.
Technical > Excel Import/Export > Sample Lead Report, error when click to export.

Mantux11 · 2022-05-16T14:14:42Z

Not sure this is ready for review. Functional test couple of action without success.

Sales > Reporting > Partner List Report

Sales > Sales Order > Quotation / Order (.xlsx) ----> not in the print action yet.

Technical > Excel Import/Export > Sample Lead Report, error when click to export.

Okey, I will test more on that. Thanks, for review

Mantux11 · 2022-05-20T09:52:51Z

@kittiu Talking about Sample Lead Report, you also missed that, this isn't working in 14 version, because planned_revenue field is deleted from 14 version. So I changed to expected_revenue, why I changed to that, you could see comparing 13 and 14 crm.lead core code. Partner List report is fixed. Talking about SO report, I see that when you press Export XLSX, you could choose what template to use in wizard. Maybe I'm wrong, but this should work as it is? Or there should be one more report? It would be really appreciated, If you could give me more example's on SO report, how it should look like,.

gaikaz · 2022-08-24T12:36:34Z

@OCA/server-environment-maintainers
Sorry to be pinging, but this is a valid migration that is just not getting any attention for 3 months now. Wouldn't want to be considered stale and closed.
Could we please get a maintainer review or two? 🙏🏻

kittiu · 2022-08-24T12:49:09Z

@gaikaz have you tested this? Can you approve this? Thanks!

kittiu · 2022-08-24T12:52:33Z

Ping @Saran440 @ps-tubtim

gaikaz · 2022-08-24T12:53:18Z

@kittiu
We'll be migrating one of our modules that depend on this, hopefully over next week.
Will do my review too.

excel_import_export/static/src/js/report/action_manager_report.esm.js

Saran440

Test with demo 👍

GreyShim · 2022-09-29T09:17:00Z

Hello guys,

Is it possible to merge the pull request ? I need this module for a project

Regards

kittiu · 2022-10-11T08:33:31Z

@Mantux11 looks like pre-commit is failing. Can you check please?

GreyShim · 2022-10-13T09:44:18Z

@Mantux11

do not forget to integrate this change : https://github.com/OCA/server-tools/pull/2283/files
it's very important, data are deleted without this

Mantux11 · 2022-10-18T07:13:58Z

@GreyShim I would wait for that PR to be merged. And I would include that here.

Mantux11 · 2022-11-24T13:54:56Z

@kittiu, @GreyShim, @Du-ma Could you review it now, please? This module is waiting in the line a long time ago. I changed what @GreyShim said that, and also, included what @luc-demeyer suggested in that PR above.

norlinhenrik

Thank you for migrating and fixing this module!

models/common.py
line = "{}.{}".format("xls", uuid.uuid4()) + "," + line
To be consistent, please change to
line = "{}.{}".format("--excel_import_export--", uuid.uuid4()) + "," + line
with underscore instead of hyphen. (I cannot write underscore since it is evaluated as bold.)

gaikaz · 2022-12-01T21:21:26Z

@Mantux11 Henrik here has very good suggestion.

@norlinhenrik
You can do \_ and have __as many underscores as you want__😉

Du-ma · 2022-12-02T08:03:41Z

Pls don't copy paste that

Mantux11 · 2022-12-05T12:29:09Z

@norlinhenrik Changed that. @Du-ma Yes I know, how you like to use f"{}" string :D

excel_import_export/models/ir_report.py

excel_import_export/wizard/import_xlsx_wizard.py

Du-ma · 2022-12-14T10:30:29Z

Also a general question, why is this module not in oca/reporting-engine?

AungKoKoLin1997

Test with demo data: work as expected
For the functional, there is a minor things.

We can remove xlrd and xlwt from external dependencies because these two are part of base odoo requirements.

Sales > Sales Order > Quotation / Order (.xlsx) ----> not in the print action yet.
We need to click manually to add this report under print action in report definition. But I think this is not a problem. We can export under action.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-excel_import_export_demo Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export_demo/

Currently translated at 5.5% (11 of 200 strings) Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/it/

Currently translated at 82.5% (165 of 200 strings) Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/it/

Because those dependencies are already part of Odoo's base dependencies.

Currently translated at 100.0% (200 of 200 strings) Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/es_AR/

…ettier

Mantux11 · 2022-12-29T12:02:52Z

@AungKoKoLin1997 I included all newest commit's history from 14.0 with commit that removes mentioned libaries, Could you review, and maybe merge this?

Or @kittiu Could you merge?

@luc-demeyer

fix from PR #2283 together with @luc-demeyer suggestion #2283 (review)

gaikaz · 2023-01-02T22:18:07Z

@kittiu
I can finally approve this 🎉
We have a client with a big excel report that uses this module for generating it and after we now have migrated the client that uses this module while internally fixing any found issues with @Mantux11, it now definitely works.

kittiu · 2023-01-02T23:45:43Z

Thank you all but I don't have power to merge. @dreispt can you help merge this? Thanks!

gaikaz · 2023-01-10T13:48:09Z

@OCA/server-environment-maintainers
Pretty please, review this 🙏🏻 This has a lot of approves with functional tests as well.
If we (Via laurea) find any issues, we'll make a PR to fix. Pinky promise.

dreispt · 2023-01-12T07:30:07Z

/ocabot merge nobump

OCA-git-bot · 2023-01-12T07:46:48Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2329-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2023-01-12T07:55:04Z

Congratulations, your PR was merged at b078df5. Thanks a lot for contributing to OCA. ❤️

Mantux11 marked this pull request as draft April 29, 2022 11:30

Mantux11 marked this pull request as ready for review May 5, 2022 14:03

Du-ma reviewed Aug 29, 2022

View reviewed changes

excel_import_export/static/src/js/report/action_manager_report.esm.js Outdated Show resolved Hide resolved

Saran440 approved these changes Sep 14, 2022

View reviewed changes

Mantux11 requested a review from Du-ma October 11, 2022 07:35

Du-ma mentioned this pull request Oct 18, 2022

[16.0] [MIG] report_xml OCA/reporting-engine#663

Merged

norlinhenrik approved these changes Dec 1, 2022

View reviewed changes

OCA-git-bot added the approved label Dec 1, 2022

Du-ma suggested changes Dec 14, 2022

View reviewed changes

OCA-git-bot removed the approved label Dec 14, 2022

AungKoKoLin1997 reviewed Dec 14, 2022

View reviewed changes

oca-transbot and others added 14 commits December 29, 2022 11:58

Update translation files

d9a5847

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/

Added translation using Weblate (Italian)

8bdb603

Translated using Weblate (Italian)

7cbfd63

Currently translated at 5.5% (11 of 200 strings) Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/it/

Translated using Weblate (Italian)

2ee6656

Currently translated at 82.5% (165 of 200 strings) Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/it/

Added translation using Weblate (Catalan)

280e1c2

Translated using Weblate (Italian)

958226d

Currently translated at 82.5% (165 of 200 strings) Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/it/

[IMP] update dotfiles

ac3049b

Translated using Weblate (Italian)

03fa06e

Currently translated at 82.5% (165 of 200 strings) Translation: server-tools-14.0/server-tools-14.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-excel_import_export/it/

[REF] excel_import_export: remove xlrd & xlwt from external dependencies

c48d439

Because those dependencies are already part of Odoo's base dependencies.

excel_import_export 14.0.1.1.0

c48e746

Added translation using Weblate (Spanish (Argentina))

1d1c798

[IMP] excel_import_export, excel_import_export_demo: black, isort, pr…

fa45e32

…ettier

Mantux11 added 2 commits December 30, 2022 14:40

[15.0][MIG] excel_import_export, excel_import_export_demo: Migration

f94ba4f

[15.0][FIX] excel_import_export, excel_import_export_demo:

5a7ce85

fix from PR #2283 together with @luc-demeyer suggestion #2283 (review)

gaikaz approved these changes Jan 2, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 12, 2023

OCA-git-bot merged commit 08afeb1 into OCA:15.0 Jan 12, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 12, 2023

Mantux11 deleted the 15.0-mig-excel_import_export,-excel_import_export_demo branch January 12, 2023 19:47

gaikaz mentioned this pull request Mar 24, 2023

[16.0][MIG] excel_import_export, excel_import_export_demo: Migration to 16.0 #2505

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] excel_import_export, excel_import_export_demo: migration #2329

[15.0][MIG] excel_import_export, excel_import_export_demo: migration #2329

Mantux11 commented Apr 29, 2022

Mantux11 commented Apr 29, 2022 •

edited

Loading

kittiu commented May 4, 2022 •

edited

Loading

Mantux11 commented May 5, 2022

kittiu commented May 16, 2022

Mantux11 commented May 16, 2022

Mantux11 commented May 20, 2022 •

edited

Loading

gaikaz commented Aug 24, 2022

kittiu commented Aug 24, 2022 •

edited

Loading

kittiu commented Aug 24, 2022

gaikaz commented Aug 24, 2022

Saran440 left a comment

GreyShim commented Sep 29, 2022

kittiu commented Oct 11, 2022

GreyShim commented Oct 13, 2022

Mantux11 commented Oct 18, 2022

Mantux11 commented Nov 24, 2022 •

edited

Loading

norlinhenrik left a comment •

edited

Loading

gaikaz commented Dec 1, 2022

Du-ma commented Dec 2, 2022

Mantux11 commented Dec 5, 2022 •

edited

Loading

Du-ma commented Dec 14, 2022 •

edited

Loading

AungKoKoLin1997 left a comment •

edited

Loading

Mantux11 commented Dec 29, 2022 •

edited

Loading

gaikaz commented Jan 2, 2023

kittiu commented Jan 2, 2023

gaikaz commented Jan 10, 2023

dreispt commented Jan 12, 2023

OCA-git-bot commented Jan 12, 2023

OCA-git-bot commented Jan 12, 2023

[15.0][MIG] excel_import_export, excel_import_export_demo: migration #2329

[15.0][MIG] excel_import_export, excel_import_export_demo: migration #2329

Conversation

Mantux11 commented Apr 29, 2022

Mantux11 commented Apr 29, 2022 • edited Loading

kittiu commented May 4, 2022 • edited Loading

Mantux11 commented May 5, 2022

kittiu commented May 16, 2022

Mantux11 commented May 16, 2022

Mantux11 commented May 20, 2022 • edited Loading

gaikaz commented Aug 24, 2022

kittiu commented Aug 24, 2022 • edited Loading

kittiu commented Aug 24, 2022

gaikaz commented Aug 24, 2022

Saran440 left a comment

Choose a reason for hiding this comment

GreyShim commented Sep 29, 2022

kittiu commented Oct 11, 2022

GreyShim commented Oct 13, 2022

Mantux11 commented Oct 18, 2022

Mantux11 commented Nov 24, 2022 • edited Loading

norlinhenrik left a comment • edited Loading

Choose a reason for hiding this comment

gaikaz commented Dec 1, 2022

Du-ma commented Dec 2, 2022

Mantux11 commented Dec 5, 2022 • edited Loading

Du-ma commented Dec 14, 2022 • edited Loading

AungKoKoLin1997 left a comment • edited Loading

Choose a reason for hiding this comment

Mantux11 commented Dec 29, 2022 • edited Loading

gaikaz commented Jan 2, 2023

kittiu commented Jan 2, 2023

gaikaz commented Jan 10, 2023

dreispt commented Jan 12, 2023

OCA-git-bot commented Jan 12, 2023

OCA-git-bot commented Jan 12, 2023

Mantux11 commented Apr 29, 2022 •

edited

Loading

kittiu commented May 4, 2022 •

edited

Loading

Mantux11 commented May 20, 2022 •

edited

Loading

kittiu commented Aug 24, 2022 •

edited

Loading

Mantux11 commented Nov 24, 2022 •

edited

Loading

norlinhenrik left a comment •

edited

Loading

Mantux11 commented Dec 5, 2022 •

edited

Loading

Du-ma commented Dec 14, 2022 •

edited

Loading

AungKoKoLin1997 left a comment •

edited

Loading

Mantux11 commented Dec 29, 2022 •

edited

Loading