Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] sale_channel_partner: add module #19

Merged
merged 17 commits into from
Feb 7, 2025
Merged

[16.0][ADD] sale_channel_partner: add module #19

merged 17 commits into from
Feb 7, 2025

Conversation

clementmbr
Copy link
Member

This module adds sale channel bindings to sale channels. For example, if you have the same customer buying from the "amazon" channel and the "ebay" channel, you can find this out through bindings.

cc @kevinkhao @florian-dacosta @bealdav

kevinkhao and others added 15 commits May 23, 2024 12:00
@clementmbr clementmbr mentioned this pull request May 23, 2024
Closed
bealdav
bealdav approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@github-actions github-actions bot closed this Nov 17, 2024
@sebastienbeau sebastienbeau reopened this Jan 17, 2025
@clementmbr clementmbr force-pushed the 16.0-add-sale-channel-partner branch from b1a2a3a to 8d40db9 Compare January 20, 2025 17:17
@clementmbr clementmbr requested a review from bealdav January 20, 2025 17:18
@clementmbr clementmbr requested a review from kevinkhao January 20, 2025 17:18
@clementmbr
Copy link
Member Author

clementmbr commented Jan 20, 2025 •
edited
Loading

FYI @sebastienbeau @bealdav @kevinkhao @florian-dacosta , I reopened this PR, correcting the Readme and adding a small fix by @nayatec .
Hope it's good for review and merge now!

This was referenced Jan 20, 2025
Open
Draft
florian-dacosta
florian-dacosta approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florian-dacosta
Copy link
Contributor

@bealdav Can you re-review since you last review is not valid anymore ?

bealdav
bealdav approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bguillot
Copy link

bguillot commented Feb 7, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-19-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4d9227a into OCA:16.0 Feb 7, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f7a2232. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bealdav bealdav bealdav approved these changes

@florian-dacosta florian-dacosta florian-dacosta approved these changes

@kevinkhao kevinkhao Awaiting requested review from kevinkhao

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@clementmbr @OCA-git-bot @florian-dacosta @bguillot @bealdav @kevinkhao @sebastienbeau @github-grap-bot @nayatec