[16.0][ADD] sale_import_base: add new module (clean history) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idating cache Test improvements on delivery carrier line generation
Co-authored-by: beau sebastien <sebastien.beau@akretion.com>
Co-authored-by: beau sebastien <sebastien.beau@akretion.com>
- add a specific validator for customer (as required field are not the same) - remove currency as it's deduce from pricelist - remove useless validate_misc due to previous change
…odels: includes SO generation, tests, components, demo data Add tests for cases where data content is full/minimal/mixed Fix state_code: search also according to country_id Fix state_code, country_code validation and search
…d raise on first error [IMP] Validate payment currency as it should match Sale Order's pricelist's currency
…e numbering Minor typo fix Minor test refactor
… make it customizable
…make sale.import.service.sale an Abstract Model
…erge and always have 2 distinct addresses In case you want to update the delivery adresse after the creation of the sale order, it is easier to already have distinct addresses between delivery and invoicing. Else one should create a new address, update the sale order, update the delivery order... In the future, it could become an option on channel or company instead of this hook that require an override to change the behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #21 with only sale_import_base commits and clean history.
sale_import_base depends on modules sale_channel_partner (#19) and queue_job_chunk (OCA/queue#737).