-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] sale_import_base: backport from v16 #94
Draft
clementmbr
wants to merge
20
commits into
14.0
Choose a base branch
from
14-sale-import-base-backport-v16
base: 14.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make sale.import.service.sale an Abstract Model
…erge and always have 2 distinct addresses In case you want to update the delivery adresse after the creation of the sale order, it is easier to already have distinct addresses between delivery and invoicing. Else one should create a new address, update the sale order, update the delivery order... In the future, it could become an option on channel or company instead of this hook that require an override to change the behavior
code is renamed ref in v16 but there is also a code in the same table in v16 this code prevent an openupgrade failing because of already existing column (code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I want to make a sale_import_amazon module for v14 but using the work I did on v16, I need a v14 of sale_import_base that is closer to the version 16 of the module.
So in this PR I added all the v16 commits from the branch that is currently being pushed to OCA/sale-channel, and also @hparfr 's last commit.
I made also the necessary backport commits to be able to use this v16 version in a v14 Odoo.
As sale_import_base depends on sale_channel, sale_channel_partner and queue_job_chunk, it's important to note that this module's version is based on :