Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] Add sale_cutoff_time_delivery #1378

Merged
merged 4 commits into from
Dec 16, 2020
Merged

[13.0] Add sale_cutoff_time_delivery #1378

merged 4 commits into from
Dec 16, 2020

Conversation

simahawk
Copy link
Contributor

Replace #1104

@simahawk simahawk mentioned this pull request Dec 16, 2020
Closed
1 task
@simahawk
Copy link
Contributor Author

@jbaudoux as per your comment here #1104 (review) if it's still valid I won't keep this blocked because it's an alpha module and we are using in it prod since quite some time now.
Let's discuss further improvements for another round.

@simahawk simahawk mentioned this pull request Dec 16, 2020
Closed
2 tasks
jgrandguillaume
jgrandguillaume approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaudoux
Copy link
Contributor

@jbaudoux as per your comment here #1104 (review) if it's still valid I won't keep this blocked because it's an alpha module and we are using in it prod since quite some time now.
Let's discuss further improvements for another round.

Can you at least put a FIXME that the comparison should be in warehouse timezone and not UTC.

@simahawk simahawk force-pushed the 13-sale_cutoff_time_delivery branch from 084c4b8 to eca213f Compare December 16, 2020 09:02
@simahawk
Copy link
Contributor Author

@jbaudoux as per your comment here #1104 (review) if it's still valid I won't keep this blocked because it's an alpha module and we are using in it prod since quite some time now.
Let's discuss further improvements for another round.

Can you at least put a FIXME that the comparison should be in warehouse timezone and not UTC.

done

@simahawk
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1378-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c21e690 into OCA:13.0 Dec 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at afa244c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandguillaume jgrandguillaume jgrandguillaume approved these changes

@TDu TDu TDu approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@simahawk @jbaudoux @OCA-git-bot @jgrandguillaume @TDu @grindtildeath @guewen