Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] Add sale_cutoff_time_weekday_delivery #1379

Closed
wants to merge 2 commits into from
Closed

[13.0] Add sale_cutoff_time_weekday_delivery #1379

wants to merge 2 commits into from

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Dec 16, 2020 •
edited
Loading

@simahawk simahawk mentioned this pull request Dec 16, 2020
Closed
2 tasks
@rousseldenis rousseldenis added this to the 13.0 milestone Jan 19, 2021
@simahawk simahawk force-pushed the 13-sale_cutoff_time_weekday_delivery branch from 4fa737e to 0986b1e Compare February 19, 2021 14:06
@simahawk simahawk force-pushed the 13-sale_cutoff_time_weekday_delivery branch from 0986b1e to d461972 Compare April 3, 2021 07:42
@guewen @simahawk
sale_partner_cutoff_delivery_window: cut-off after delivery window
4bcfed0 
When a customer has a delivery time window, we want to apply the cut-off
time on the scheduded date.

Whenever we have a customer with weekly delivery, the scheduled datetime
of the delivery must be set at the cut-off time for this order:

* e.g. I set a customer to be shipped on Tuesday and Thursday between 13:55-14:30,
* I place a SO on the 29th of November 2020, my scheduled datetime on my
  delivery must be 1st december at 09:00
* 1st december because it is the next Tuesday from the order creation
* 09:00 because my cut-off time for WH is set at 09:00 and the customer
  doesn't have any specific cut-off time
@simahawk simahawk force-pushed the 13-sale_cutoff_time_weekday_delivery branch from d461972 to 4bcfed0 Compare April 3, 2021 07:43
@dreispt
Copy link
Member

dreispt commented May 1, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1379-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 1, 2021
@OCA-git-bot
Merge PR #1379 into 13.0
9bef1f1 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1379-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sebalix
Copy link
Contributor

sebalix commented Jan 10, 2022

NOTE: this feature has been merged in the new module sale_delivery_date in 14.0.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 27, 2022
@github-actions github-actions bot closed this Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu approved these changes

@mmequignon mmequignon mmequignon approved these changes

Assignees
No one assigned
Labels
approved needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
9 participants
@simahawk @dreispt @OCA-git-bot @sebalix @TDu @mmequignon @rousseldenis @grindtildeath @guewen