Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Add module sale_cutoff_time_weekday_delivery #1107

Conversation

grindtildeath
Copy link
Contributor

@grindtildeath grindtildeath commented Mar 27, 2020

Depends on:

This module adds some unittests to ensure Method Resolution Order of
sale.order.line._prepare_procurement_values for modules
sale_cutoff_time_delivery and sale_partner_delivery_window is correct.

@grindtildeath grindtildeath force-pushed the 13.0-add-sale_cutoff_time_weekday_delivery branch from f019834 to ee17806 Compare March 27, 2020 11:59
@grindtildeath grindtildeath force-pushed the 13.0-add-sale_cutoff_time_weekday_delivery branch from be4fc44 to 8565b05 Compare April 8, 2020 13:41
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ensure that cutoff computation is applied before time window. If after cutoff, we add a day. Then, if not in the time window, we add additional days.
When I tested, it executed in the contrary order

@grindtildeath
Copy link
Contributor Author

@jbaudoux This test (https://github.com/OCA/sale-workflow/pull/1107/files#diff-4d050161f1bf44a1ee247ea0e214f592R194-R230) must ensure MRO is correct. Can you check if you still have issues after the refresh of submodules?

@rousseldenis rousseldenis added this to the 13.0 milestone Jul 28, 2020
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test, work great

When a customer has a delivery time window, we want to apply the cut-off
time on the scheduded date.

Whenever we have a customer with weekly delivery, the scheduled datetime
of the delivery must be set at the cut-off time for this order:

* e.g. I set a customer to be shipped on Tuesday and Thursday between 13:55-14:30,
* I place a SO on the 29th of November 2020, my scheduled datetime on my
  delivery must be 1st december at 09:00
* 1st december because it is the next Tuesday from the order creation
* 09:00 because my cut-off time for WH is set at 09:00 and the customer
  doesn't have any specific cut-off time
@simahawk
Copy link
Contributor

replaced by #1379

@simahawk simahawk closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants