Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FW] [13.0][IMP]base_user_role: Groups-roles navigation #158

Closed
wants to merge 1 commit into from

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Apr 20, 2022

Port of #157 from 13.0 to 14.0.

@OCA-git-bot
Copy link
Contributor

Hi @jcdrubay, @novawish,
some modules you are maintaining are being modified, check this out!

@sebalix sebalix added this to the 14.0 milestone Apr 20, 2022
@sebalix sebalix marked this pull request as ready for review April 20, 2022 12:13
@GuillemCForgeFlow
Copy link
Contributor

Hi @sebalix, I opened this FW: #159 before I saw that this PR had been created. If you agree, you can close this PR as the one I opened already has some changes that were necessary on v14.0 and it has the approved label already. Let me know if that sounds good! 😄

Comment on lines +63 to +64
action = self.env["ir.actions.act_window"].for_xml_id(
"base_user_role", "action_res_users_role_tree"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
action = self.env["ir.actions.act_window"].for_xml_id(
"base_user_role", "action_res_users_role_tree"
action = self.env["ir.actions.act_window"]._for_xml_id(
"base_user_role.action_res_users_role_tree"

Here are the changes I mentioned

@GuillemCForgeFlow
Copy link
Contributor

Also, I will be opening a FW for v15.0. @sebalix

@sebalix
Copy link
Contributor Author

sebalix commented Apr 20, 2022

@GuillemCForgeFlow all good, I close this one, thanks!

@sebalix sebalix closed this Apr 20, 2022
SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-backend (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants