Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP]base_user_role: Groups-roles navigation #157

Merged
merged 1 commit into from
Apr 20, 2022
Merged

[13.0][IMP]base_user_role: Groups-roles navigation #157

merged 1 commit into from
Apr 20, 2022

Conversation

GuillemCForgeFlow
Copy link
Contributor

This PR improves the module base_user_role, implementing the navigation from the groups to the roles. It's not implemented the other way around as the groups can already be accessed through the main view of any role.

@OCA-git-bot
Copy link
Contributor

Hi @sebalix, @jcdrubay, @novawish,
some modules you are maintaining are being modified, check this out!

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-base_user_role-group_role_navigation branch 3 times, most recently from 963cb94 to eee0038 Compare April 19, 2022 11:00
JordiMForgeFlow
JordiMForgeFlow approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature 🔝 ! Code + functional review LGTM 👍🏼

mariadforgeflow
mariadforgeflow approved these changes Apr 19, 2022
View reviewed changes
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code & functional review.

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-base_user_role-group_role_navigation branch from eee0038 to 69af8dd Compare April 20, 2022 08:08
@sebalix
Copy link
Contributor

sebalix commented Apr 20, 2022 •
edited
Loading

@GuillemCForgeFlow oups, one last thing: can you remove the reference to the Odoo version in your commit message? ([13.0])
When we backport or forward port commits from one branch to another this info becomes useless, and we avoid to change the commit messages when porting commits so we can compare them among different branches.

Side note: this doesn't apply for migration commits, as the changes they bring are really related to the current version of Odoo.

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 13.0-imp-base_user_role-group_role_navigation branch from 69af8dd to 2126213 Compare April 20, 2022 09:31
@GuillemCForgeFlow
Copy link
Contributor Author

Perfect! I've changed the commit message! 👍

@sebalix sebalix added this to the 13.0 milestone Apr 20, 2022
@sebalix
Copy link
Contributor

sebalix commented Apr 20, 2022

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-157-by-sebalix-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ae3d9e0 into OCA:13.0 Apr 20, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 429cc0d. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-imp-base_user_role-group_role_navigation branch April 20, 2022 10:02
@sebalix sebalix mentioned this pull request Apr 20, 2022
Closed
This was referenced Apr 20, 2022
Merged
Merged
Merged
SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#157 from OCA/14.0
bf45535 
Syncing from upstream OCA/server-backend (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariadforgeflow mariadforgeflow mariadforgeflow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillemCForgeFlow @OCA-git-bot @sebalix @JordiMForgeFlow @mariadforgeflow