Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FW]base_user_role: Groups-roles navigation #160

Merged
merged 1 commit into from
Jun 20, 2022
Merged

[15.0][FW]base_user_role: Groups-roles navigation #160

merged 1 commit into from
Jun 20, 2022

Conversation

GuillemCForgeFlow
Copy link
Contributor

@ForgeFlow
ForwardPort of #157 from 13.0 to 15.0.

@OCA-git-bot
Copy link
Contributor

Hi @sebalix, @jcdrubay, @novawish,
some modules you are maintaining are being modified, check this out!

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 15.0-fw-base_user_role-groups_roles_navigation branch from bddab56 to 15eed5b Compare April 20, 2022 14:37
HaraldPanten
HaraldPanten approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 15.0-fw-base_user_role-groups_roles_navigation branch from 15eed5b to b0ead59 Compare April 20, 2022 14:41
sebalix
sebalix reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark than in #159 to preserve the original commit

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 15.0-fw-base_user_role-groups_roles_navigation branch 2 times, most recently from 2df6b3f to e9fa039 Compare April 21, 2022 14:56
@sebalix
Copy link
Contributor

sebalix commented Apr 21, 2022

@GuillemCForgeFlow Runboat isn't happy, can you check?

@MiquelRForgeFlow
Copy link

Runboat isn't happy because he reintroduced by error same previous bugs:
Selection_340

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 15.0-fw-base_user_role-groups_roles_navigation branch from e9fa039 to 06b7ef6 Compare April 22, 2022 06:46
@GuillemCForgeFlow
Copy link
Contributor Author

Runboat isn't happy because he reintroduced by error same previous bugs: Selection_340

Fixed! 😉

@sebalix
Copy link
Contributor

sebalix commented Apr 22, 2022

@GuillemCForgeFlow thanks for the follow-up on all versions!

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-160-by-sebalix-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 22, 2022
@OCA-git-bot
Merge PR #160 into 15.0
8a95cb8 
Signed-off-by sebalix
@OCA-git-bot
Copy link
Contributor

@sebalix your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-160-by-sebalix-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sebalix
Copy link
Contributor

sebalix commented Apr 22, 2022

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-160-by-sebalix-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 22, 2022
@OCA-git-bot
Merge PR #160 into 15.0
df024f7 
Signed-off-by sebalix
@OCA-git-bot
Copy link
Contributor

@sebalix your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-160-by-sebalix-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 15.0-fw-base_user_role-groups_roles_navigation branch from 06b7ef6 to 74b6b82 Compare June 20, 2022 11:57
@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 15.0-fw-base_user_role-groups_roles_navigation branch from 74b6b82 to b3e81ac Compare June 20, 2022 12:03
@StefanRijnhart
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-160-by-StefanRijnhart-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 73bc6d6 into OCA:15.0 Jun 20, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e39abc4. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-fw-base_user_role-groups_roles_navigation branch June 21, 2022 07:54
SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#160 from OCA/14.0
daea554 
Syncing from upstream OCA/server-backend (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@sebalix sebalix sebalix approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillemCForgeFlow @OCA-git-bot @sebalix @MiquelRForgeFlow @StefanRijnhart @HaraldPanten