Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] base_custom_filter: Migration to 15.0 #573

Merged
merged 16 commits into from
May 17, 2023

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Jan 6, 2023

This migration is done by cherry-pick of each commit from commit history because there are issues using maintainer-tools for migration.
I squash the two commit [MIG] base_custom_filter: Migration to 14.0 and [IMP] base_custom_filter: black, isort, prettier into [MIG] base_custom_filter: Migration to 14.0 because these two commits have the same changes and I got nothing to commit when commit [MIG] base_custom_filter: Migration to 14.0 after commit [IMP] base_custom_filter: black, isort, prettier.

nothingtocommit

Related issue: #571
@qrtl

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft January 6, 2023 03:13
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-mig-base_custom_filter branch from 07c7c34 to 37f9c1b Compare January 6, 2023 03:28
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review January 6, 2023 03:39
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-mig-base_custom_filter branch from 5b0cbc7 to 2b7c20a Compare January 6, 2023 03:45
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft January 6, 2023 04:11
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-mig-base_custom_filter branch from 2b7c20a to cce2164 Compare January 6, 2023 04:23
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review January 6, 2023 04:35
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. 👍

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-mig-base_custom_filter branch from cce2164 to 8397a68 Compare April 6, 2023 04:35
Copy link

@vincent-cowboy vincent-cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (functional review). Thank you for this PR 🙏

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@victoralmau
Copy link
Member

Please, cherry-pick #657 to commit history

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK

@pedrobaeza
Copy link
Member

/ocabot migration base_custom_filter
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone May 17, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-573-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request May 17, 2023
34 tasks
@OCA-git-bot OCA-git-bot merged commit af78b01 into OCA:15.0 May 17, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6e16635. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.