Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] base_custom_filter: Prevent all records from being displayed in favorites #657

Merged

Conversation

victoralmau
Copy link
Member

Prevent all records from being displayed in favorites

Please @pedrobaeza and @pilarvargas-tecnativa can you review it?

@Tecnativa TT43350

@OCA-git-bot
Copy link
Contributor

Hi @ForgeFlow, @AshishHirapara,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 14.0 milestone May 16, 2023
@victoralmau victoralmau force-pushed the 14.0-fix-base_custom_filter-favorite branch from 1ce586f to 5478942 Compare May 16, 2023 16:20
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-657-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3a425e9 into OCA:14.0 May 17, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a34ac72. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants