-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] base_custom_filter: Migration to 16.0 #652
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-14.0/server-ux-14.0-base_custom_filter Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_custom_filter/
Currently translated at 100.0% (21 of 21 strings) Translation: server-ux-14.0/server-ux-14.0-base_custom_filter Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_custom_filter/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review / no code review. 👍 thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
lang = self.env.lang or "en_US" | ||
self._cr.execute( | ||
"SELECT model, COALESCE(name->>%s, name->>'en_US') FROM ir_model ORDER BY 2", | ||
[lang], | ||
) | ||
return self._cr.fetchall() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lang = self.env.lang or "en_US" | |
self._cr.execute( | |
"SELECT model, COALESCE(name->>%s, name->>'en_US') FROM ir_model ORDER BY 2", | |
[lang], | |
) | |
return self._cr.fetchall() | |
return self.env["ir.filters"]._list_all_models() |
This PR has the |
abde10b
to
285a0a0
Compare
Please, cherry-pick #657 to commit history |
… favorites TT43350
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review OK
/ocabot migration base_custom_filter |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 7e909aa. Thanks a lot for contributing to OCA. ❤️ |
@qrtl