Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] base_custom_filter: Migration to 16.0 #652

Merged
merged 17 commits into from
May 17, 2023

Conversation

AungKoKoLin1997
Copy link
Contributor

Copy link
Contributor

@kikopeiro kikopeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review / no code review. 👍 thanks !

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Comment on lines 36 to 41
lang = self.env.lang or "en_US"
self._cr.execute(
"SELECT model, COALESCE(name->>%s, name->>'en_US') FROM ir_model ORDER BY 2",
[lang],
)
return self._cr.fetchall()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lang = self.env.lang or "en_US"
self._cr.execute(
"SELECT model, COALESCE(name->>%s, name->>'en_US') FROM ir_model ORDER BY 2",
[lang],
)
return self._cr.fetchall()
return self.env["ir.filters"]._list_all_models()

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@victoralmau
Copy link
Member

Please, cherry-pick #657 to commit history

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK

@pedrobaeza
Copy link
Member

/ocabot migration base_custom_filter
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-652-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 17, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 17, 2023
26 tasks
@OCA-git-bot OCA-git-bot merged commit 2e8a77d into OCA:16.0 May 17, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7e909aa. Thanks a lot for contributing to OCA. ❤️

@AungKoKoLin1997 AungKoKoLin1997 deleted the 16.0-mig-base_custom_filter branch May 22, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.