Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] mail_send_confirmation #1234

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][ADD] mail_send_confirmation #1234

wants to merge 1 commit into from

Conversation

AungKoKoLin1997
Copy link
Contributor

Recreated for #1074

@qrtl

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_send_confirmation branch 4 times, most recently from 1a46553 to 4a71ed2 Compare January 5, 2024 08:29
@AungKoKoLin1997
Copy link
Contributor Author

Tests will be fixed when this PR #1277 got merged.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_send_confirmation branch from 4a71ed2 to 675f9a0 Compare January 8, 2024 02:03
kanda999
kanda999 approved these changes Jan 15, 2024
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: It works as expected

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_send_confirmation branch from 675f9a0 to 384c0a8 Compare May 20, 2024 02:22
@jans23
Copy link

jans23 commented May 20, 2024

In our situation we have some internal users who configured their profile to receive messages from Odoo via email. And we have customer (portal) users who potentially configured to not receive messages via email. Thus we developed a module which asks for a confirmation if a message is going to be sent to a portal user, no matter of their profile's configuration. I think this approach is more versatile and might work for you as well.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
BT-tmeichtry
BT-tmeichtry approved these changes Aug 5, 2024
View reviewed changes
Copy link

@BT-tmeichtry BT-tmeichtry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: Code looks good

@BT-tmeichtry
Copy link

@OCA/social-maintainers Is it possible to take a look at this PR?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_send_confirmation branch from 384c0a8 to 547f4af Compare August 5, 2024 09:37
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_send_confirmation branch from 547f4af to 493d390 Compare November 15, 2024 09:31
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_send_confirmation branch from 493d390 to 1742b48 Compare November 15, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-tmeichtry BT-tmeichtry BT-tmeichtry approved these changes

@kanda999 kanda999 kanda999 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AungKoKoLin1997 @jans23 @BT-tmeichtry @kanda999 @OCA-git-bot