[15.0][IMP] mail_composer_cc_bcc: filter out partner with no email address and set "" for partner with no name #1293
Conversation
|
Hi @hailangvn2023, |
sonhd91
changed the title
| emails = [ | ||
| tools.formataddr((p.name or "False", p.email or "False")) for p in partners | ||
| ] | ||
| emails = [tools.formataddr((p.name or "", p.email)) for p in partners if p.email] |
There was a problem hiding this comment.
| emails = [tools.formataddr((p.name or "", p.email)) for p in partners if p.email] | |
| emails = [tools.formataddr((p.name, p.email)) for p in partners if p.email] |
- Normally a wizard opens on Odoo client side to prompt user to define an email address for partners that don't have one - But it's possible to bypass it, so we explicitly filter out partners with no email address - We also return "" instead of "False" for partner with no name, and odoo's tools.formataddr will just use the partner's email address
sonhd91
force-pushed
the
15.0-imp-mail_composer_cc_bcc
branch
from
7855319 to
ef21fb0
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hello, can this PR be reopened and merged? Unless that I have opened a new one to be able to do a followup if requested. |
|
Hi @hailangvn2023, |
|
/ocabot merge minor no idea what's going on with runboat, and I'm overriding @hailangvn2023 as this handle seems inactive. The module should get a new maintainer then or be orphaned |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7c072b1. Thanks a lot for contributing to OCA. ❤️ |
tools.formataddrwill just use the partner's email address