Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] mail_composer_cc_bcc: filter out partner with no email address and set "" for partner with no name #1488

Closed

Conversation

leemannd
Copy link

@leemannd leemannd commented Nov 5, 2024

  • Normally a wizard opens on Odoo client side to prompt user to define an email address for partners that don't have one
  • But it's possible to bypass it, so we explicitly filter out partners with no email address
  • We also return "" instead of "False" for partner with no name, and odoo's tools.formataddr will just use the partner's email address

The original PR can be found in: #1293
I'm opening a new one to try to have it merged and to be able to do the followup

- Normally a wizard opens on Odoo client side to prompt user to define an email address for partners that don't have one
- But it's possible to bypass it, so we explicitly filter out partners with no email address
- We also return "" instead of "False" for partner with no name, and odoo's tools.formataddr will just use the partner's email address
@OCA-git-bot
Copy link
Contributor

Hi @hailangvn2023,
some modules you are maintaining are being modified, check this out!

@leemannd
Copy link
Author

leemannd commented Nov 5, 2024

Hello @hbrunn , I have opened this PR. It is related to: #1293
Do you prefer to review this one, or to reopen the original one so I can add a review and then it can be merged?

@leemannd leemannd changed the title [IMP] mail_composer_cc_bcc: corner cases [15.0][IMP] mail_composer_cc_bcc: filter out partner with no email address and set "" for partner with no name Nov 5, 2024
@hbrunn
Copy link
Member

hbrunn commented Nov 5, 2024

you can review closed prs, so please don't duplicate them like this again

@hbrunn hbrunn closed this Nov 5, 2024
@leemannd
Copy link
Author

leemannd commented Nov 5, 2024

Hello, I can only add a comment into the PR. Is it possible to reopen the original one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants