[17.0][ADD]mute_notification_user_autosubscribe: Do not send notification to users autosubscribed through user_id field

[manuelregidor]

@HaraldPanten @ValentinVinagre

@luis-ron Could you review, please?

T-6499

[pedrobaeza]

Please avoid plurals in module names, and more in the middle of the name. That's food for constant typos.

[manuelregidor]

@pedrobaeza done

[HaraldPanten]

@manuelregidor Could you adapt the commit and the PR names, considering the correct module name, please? mute_notifications_user_autosubscribe --> mute_notification_user_autosubscribe

[manuelregidor]

@HaraldPanten done

[HaraldPanten]

Let's wait for @luis-ron 's functional review, then.

[luis-ron]

Functional review: LGTM 👍🏻

[manuelregidor]

@Tisho99 Could you review, please?

[Tisho99]

LGTM. Technical review

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[ValentinVinagre]

LGTM 👍🏻

[HaraldPanten]

@pedrobaeza @etobella your point of view here would be nice.

Could you give us a hand?

THX

[manuelregidor]

@pedrobaeza Changes applied

[pedrobaeza]

Well, this is replacement one table (the previous one) by another (the followers one). The question is why can't you determine dynamically in the moment of sending the notification if it should be sent or not.

[manuelregidor]

@pedrobaeza We decided to use subtypes to avoid notificactions, so the muting subtype is applied only once, when the user in field user_id is autosubscribed, and after that, notifications will not be sent to this user unless subtypes in the document are changed, with no need of further checks. By doing it this way:

• It is easy to keep a user subscribed to the document while not receiving notifications.
• In case the user needs to receive notifications, the subtypes can be easily changed.
• We can check which contacts are being sent notifications and which are not in each document.

I hope that answers your question.

[pedrobaeza]

As said, I don't think this is the way to go, as if you change any mute rule, all the existing documents won't have such configuration, but if you want to go this way, put it on the ROADMAP and I won't block it.

[HaraldPanten]

As said, I don't think this is the way to go, as if you change any mute rule, all the existing documents won't have such configuration, but if you want to go this way, put it on the ROADMAP and I won't block it.

@pedrobaeza

The use case is:

• We have a Sales team that prepare lots of quotations and sales orders (after confirmation).
• Once these sales orders are processed (materials are delivered, etc.) we create the corresponding invoices.
• When the Accounting team creates the invoice, the Salesperson assigned to the invoice musn't receive notifications when the invoices are sent by email.
• We need to keep the Salesperson as a follower, but they should not receive notifications coming from the invoices, as it is an Accounting issue, not Sales.

Do you know what I mean?

I'm not sure about what you mean. Could you give us more details and which would be a better approach for this situation?

THX

[pedrobaeza]

As said, if you change any mute rule, all the existing documents won't have such configuration, but it's just a corner case. You can continue putting that case in the ROADMAP.

[manuelregidor]

@pedrobaeza Case included in ROADMAP.

[pedrobaeza]

OK, you can go ahead then.

[HaraldPanten]

@pedrobaeza Could you merge it, please? I'm not PSC of this repository.

THX!

[etobella]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1460-by-etobella-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 2299f2d. Thanks a lot for contributing to OCA. ❤️