Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_orderpoint_manual_procurement: Migration to version 15.0 #1641

Conversation

ernesto-garcia-tecnativa
Copy link
Contributor

@Tecnativa TT37320

JordiBForgeFlow and others added 25 commits February 15, 2023 18:26
[ADD] stock_orderpoint_procure_uom
…n context to be able to have it through a chain of procuremets.
@ernesto-garcia-tecnativa ernesto-garcia-tecnativa force-pushed the 15.0-mig-stock_orderpoint_manual_procurement branch from c596935 to ad66cf5 Compare February 16, 2023 01:21
@ernesto-garcia-tecnativa
Copy link
Contributor Author

@pedrobaeza @victoralmau please review

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this module features overlap with the already existing in core where you can force a procurement, analyze the stock forecast...:

image

What do you think @pedrobaeza ?

@pedrobaeza
Copy link
Member

I'm afraid it's not exactly the same, as Odoo feature is only real demand, and not based on a past period, but this generator extrapolates the amounts of the given range for having the corresponding reordering rules.

It should be migrated, but several things:

  1. The README is very outdated, even mentioning a non-existing security group. Please update it.
  2. There's an ACL that I don't like too much, because it's very broad. Please review why it's needed, and find an alternative.
  3. Please be sure the created reordering rules are not overwritten when entering again on the replenishment screen.

@ernesto-garcia-tecnativa ernesto-garcia-tecnativa force-pushed the 15.0-mig-stock_orderpoint_manual_procurement branch from ad66cf5 to 0870f76 Compare February 25, 2023 00:03
@ernesto-garcia-tecnativa
Copy link
Contributor Author

@pedrobaeza please review

@pedrobaeza
Copy link
Member

/ocabot migration stock_orderpoint_manual_procurement

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 25, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 25, 2023
80 tasks
@pedrobaeza
Copy link
Member

Oh, I'm ashamed. I have totally mixed this module with stock_orderpoint_generator. Indeed @chienandalu was right, and this one is not needed, as now Odoo includes the possibility of doing the same.

The only pain points:

  • Reordering rules are created automatically by Odoo. We have to check the persistence of the manual ones. There's a filter "Trigger: Manual", so it seems OK, but not 100% sure.
  • There's no specific security group for doing that.

For now, let's close this and merge it with stock in OpenUpgrade, and check if there's no problem in the customer with these pain points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.