[11.0][MIG] stock_warehouse_orderpoint_stock_info_unreserved #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
requested changes
Feb 20, 2018
| super()._compute_product_available_qty() | ||
| op_by_loc = defaultdict(lambda: self.env['stock.warehouse.orderpoint']) | ||
| for order in self: | ||
| op_by_loc[order.location_id] |= order |
There was a problem hiding this comment.
This pattern of extending the recordset is very slow compared to using a true set, then create a new recordset out of the final set. See OCA/connector-prestashop@5d617fd
mpanarin
force-pushed
the
11.0-mig-stock_warehouse_orderpoint_stock_info_unreserved
branch
from
f8ed2d4 to
a850532
Compare
guewen
approved these changes
Mar 1, 2018
asaunier
approved these changes
Mar 12, 2018
| super(TestStockWarehouseOrderpoint, self).setUp() | ||
| class TestStockWarehouseOrderpoint(SavepointCase): | ||
| @classmethod | ||
| def setUpClass(cls): |
There was a problem hiding this comment.
Just a candid question: what's the point of renaming self to cls?
Edit: OK, it's a pep8 recommendation, see https://www.python.org/dev/peps/pep-0008/#function-and-method-arguments
Always use self for the first argument to instance methods.
Always use cls for the first argument to class methods.
21 tasks
|
Dependency is merged. Please rebase. |
LoisRForgeFlow
changed the title
|
@mpanarin can you rebase? |
…10.0 [IMP] fast compute _product_available() method is computed only once by location [FIX] stock_available: Some affectations
mpanarin
force-pushed
the
11.0-mig-stock_warehouse_orderpoint_stock_info_unreserved
branch
from
a850532 to
ddbe8ed
Compare
gurneyalex
approved these changes
Mar 26, 2018
bodedra
approved these changes
Mar 26, 2018
46 tasks
ps-tubtim
pushed a commit
to ecosoft-odoo/stock-logistics-warehouse
that referenced
this pull request
Dec 18, 2019
…y unit for a product (OCA#377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on