Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] stock_inventory_lockdown #479

Merged
merged 9 commits into from
Oct 23, 2018

Conversation

LoisRForgeFlow
Copy link
Contributor

Migration to v11.

Lionel Sausin & Loïc Bellier and others added 6 commits September 12, 2018 16:18
This module is a feature extracted from stock_inventory_location.

Ported to v8 and new API
Adopted latest OCA standards
Added tests
 in stock move instead of checks in quants. This will allow for a more
 robust lockdown, and still make it possible to perform inventory adjustments
 in the locked location. Also resolves an outstanding issue related to the
 previous design not allowing inventory adjustments where negative quants existed.
@LoisRForgeFlow LoisRForgeFlow force-pushed the 11.0-mig-stock_inventory_lockdown branch from 8ae9ec1 to 20393a5 Compare September 12, 2018 14:54
@LoisRForgeFlow LoisRForgeFlow force-pushed the 11.0-mig-stock_inventory_lockdown branch from 20393a5 to cb10ddb Compare September 12, 2018 14:55
@pedrobaeza pedrobaeza added this to the 11.0 milestone Sep 12, 2018
@LoisRForgeFlow
Copy link
Contributor Author

@sbidoul FYI, I ran oca-gen-addon-readme in my local for this module and I got an error due to an author with a non-ascii name ("Numérigraphe"). I don't know whether this was only a local issue or it can happen after merge.

@pedrobaeza
Copy link
Member

That's because you have installed maintainer-tools for Python 2 instead of Python 3.

@LoisRForgeFlow LoisRForgeFlow force-pushed the 11.0-mig-stock_inventory_lockdown branch from cb10ddb to a202852 Compare September 12, 2018 15:09
@LoisRForgeFlow
Copy link
Contributor Author

@pedrobaeza You are right! Thanks. pre-generated README added.

@sbidoul
Copy link
Member

sbidoul commented Sep 12, 2018

As Lucky @pedrobaeza Luke says :)

image

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, tested ok

@gurneyalex gurneyalex merged commit f244927 into OCA:11.0 Oct 23, 2018
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-mig-stock_inventory_lockdown branch October 25, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants