Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] stock_cycle_count #484

Merged
merged 31 commits into from
Oct 31, 2018

Conversation

LoisRForgeFlow
Copy link
Contributor

Migration to v11.

LoisRForgeFlow and others added 30 commits September 19, 2018 16:05
 * Update README.
 * Fixes: DEFAULT_SERVER_DATETIME_FORMAT, PERCENT variables and sale price calculation.
…tment related to a cycle count cannot be modified.
* simplify fetching latest inventory date
* use api.depends where needed
* add hook for cycle count creation
* take advantage of api.multi on check_zero_confirmation method
@LoisRForgeFlow LoisRForgeFlow added this to the 11.0 milestone Sep 19, 2018
@pedrobaeza pedrobaeza mentioned this pull request Oct 1, 2018
46 tasks
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@@ -11,6 +10,7 @@ class StockCycleCount(models.Model):
_name = 'stock.cycle.count'
_description = "Stock Cycle Counts"
_inherit = 'mail.thread'
_order = "id desc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lreficent Is this change can break behaviours with existing data (e.g. : when migrating)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis How?

FYI I'm currently working on a migration that includes this module, if it generates any issue I will probably see it soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the flow exactly but sometimes changing something small as the order can lead to weird behaviours usually when manipulating multiple recordsets (as it changes recordset ordering).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I will bear it in mind and try to see if anything strange happen.

@rousseldenis
Copy link
Contributor

@jbeficent @lreficent What's the status of this ?

@LoisRForgeFlow
Copy link
Contributor Author

@rousseldenis I think it is just fine, no problem until now.

@JordiBForgeFlow JordiBForgeFlow merged commit 21b18d3 into OCA:11.0 Oct 31, 2018
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-mig-stock_cycle_count branch October 31, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants