-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] stock_cycle_count #484
[11.0][MIG] stock_cycle_count #484
Conversation
* Update README. * Fixes: DEFAULT_SERVER_DATETIME_FORMAT, PERCENT variables and sale price calculation.
…manual creation of cycle counts.
…racking to some of them.
…tment related to a cycle count cannot be modified.
* simplify fetching latest inventory date * use api.depends where needed * add hook for cycle count creation * take advantage of api.multi on check_zero_confirmation method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
@@ -11,6 +10,7 @@ class StockCycleCount(models.Model): | |||
_name = 'stock.cycle.count' | |||
_description = "Stock Cycle Counts" | |||
_inherit = 'mail.thread' | |||
_order = "id desc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lreficent Is this change can break behaviours with existing data (e.g. : when migrating)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis How?
FYI I'm currently working on a migration that includes this module, if it generates any issue I will probably see it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the flow exactly but sometimes changing something small as the order can lead to weird behaviours usually when manipulating multiple recordsets (as it changes recordset ordering).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, I will bear it in mind and try to see if anything strange happen.
@jbeficent @lreficent What's the status of this ? |
@rousseldenis I think it is just fine, no problem until now. |
Migration to v11.