[MIG] stock_quant_manual_assign: Migration to 11.0 #508

cubells · 2018-11-12T06:28:09Z

Migration standard of module.

cc @Tecnativa

Supersede #361

cubells · 2018-11-12T07:17:28Z

@lreficent , @rousseldenis , @pedrobaeza can you test again this?

fanha99 · 2018-11-12T07:38:42Z

Hi @cubells , in my pull request, some auto test case was removed.
Is it better to check and fix them, also?

cubells · 2018-11-12T08:31:33Z

@fanha99 I've updated tests. I think all cases are covered.

pedrobaeza · 2018-11-13T14:42:13Z

Works very well. Only 2 minor things:

Change the widget of the check for being toggle widget, so that you don't have to click 2 times for selecting a line.
If you have already selected all the quantity needed, when you press on other line the "Select" check, if turns selected, but no quantity is added, so this is weird. I think in 2 possibilities:
- To turn to readonly the fields where quantity = 0 and parent.remaning quantity = 0, so when you select last possible line, the rest is not possible to be selected. This one is more UX friendly.
- On the onchange of the check, go back to unchecked if the quantity is 0.

LoisRForgeFlow

Issues I saw in the other PR are solved. Thanks 👍

rousseldenis

Code review.

Main part is about move link which can be done through a field.

stock_quant_manual_assign/wizard/assign_manual_quants.py

pedrobaeza · 2018-11-16T00:39:15Z

@cubells it seems the toggle button is working even worst. Have you tried? I remember that Odoo fixed for not needing 2 clicks for using it, but it seems it's not true. We can see this together tomorrow.

… the wizard of "quants Manual" and check availability.

* Extended usage in README

…automatically

Conforms to the latest README template: bugtracker, runbot etc. Fixes bugtracker URL on some modules. States OCA as maintainer, removes other contributors from the 'Maintainer' section.

* Fix uom issue * Convert move quantity in the default product uom to use the same uom as quant

[FIX] test_flake8 [FIX] - use the already existing field product_qty - fix picking edition by warehouse user due to related none readonly field

cubells · 2018-11-16T16:47:55Z

@pedrobaeza
I've tested your two options proposed and if I change readonly attribute of selected fields in view, readonly attribute is not setted to selected in any moment.
And if I change onchange method of selected field, user has to click on checkbox twice to enter quantity.
So I leave code as is.

fanha99

LGTM

LoisRForgeFlow · 2018-11-19T11:00:40Z

@pedrobaeza @rousseldenis Could you guys check if this is good to go for you now?

* Better layout * Remove active_id dependency in some computed fields * Clean code * Refine constraint * Take into account if the current line is previously reserved before clicking on the button.

pedrobaeza · 2018-11-21T00:10:09Z

@rousseldenis I have attended your comments and also improve the module with:

Better layout
Remove active_id dependency in some computed fields
Clean code
Refine constraint
Take into account if the current line is previously reserved before clicking on the button.

so all your comments have been honored. If you don't answer in a couple of days, I'll merge this.

rousseldenis

Code review. LGTM

OCA-git-bot · 2018-11-21T06:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

…ative [12.0][MIG] Migration of stock_no_negative

cubells mentioned this pull request Nov 12, 2018

[11.0] [MIG] stock_quant_manual_assign #361

Closed

cubells force-pushed the 11.0-mig-stock_quant_manual_assign branch from 1469178 to dd438e3 Compare November 12, 2018 06:42

cubells force-pushed the 11.0-mig-stock_quant_manual_assign branch from dd438e3 to c3f622e Compare November 12, 2018 08:31

pedrobaeza added this to the 11.0 milestone Nov 13, 2018

pedrobaeza added the needs review label Nov 13, 2018

LoisRForgeFlow approved these changes Nov 13, 2018

View reviewed changes

rousseldenis requested changes Nov 13, 2018

View reviewed changes

cubells force-pushed the 11.0-mig-stock_quant_manual_assign branch from dde313c to b3e83a8 Compare November 16, 2018 07:23

avanzosc1 and others added 17 commits November 16, 2018 17:41

[mod] added qty control

f1467c0

[mod]

482478e

[mod] _rec_name

2f15f4f

[mod] new_api

37e50e4

[fix] null lines error and remaining qty assign

fa7ec8b

[MOD] Fixed some problems when there are quants with diferente histories

d1f9d9f

[IMP] Expand AUTHORS

30d7186

[IMP] stock_quant_manual_assign: Delete picking operations to confirm…

a917b2b

… the wizard of "quants Manual" and check availability.

OCA Transbot updated translations from Transifex

e5bdb81

[IMP] stock_quant_manual_assign: added tests

3e0aea7

[IMP] stock_quant_manual_assign: Tests for missing cases

00a224f

[IMP] stock_quant_manual_assign:

1534cd7

* Extended usage in README

OCA Transbot updated translations from Transifex

6124df4

[IMP] stock_quant_manual_assign: Add lot and package to selection view

12e450f

[FIX] stock_quant_manual_assign: lot_id and package_id not populated …

08549cb

…automatically

Update READMEs

2409b73

Conforms to the latest README template: bugtracker, runbot etc. Fixes bugtracker URL on some modules. States OCA as maintainer, removes other contributors from the 'Maintainer' section.

OCA Transbot updated translations from Transifex

dec5de7

pedrobaeza and others added 13 commits November 16, 2018 17:42

[FIX] stock_quant_manual_assign: Search in all child locations

edeb8fd

OCA Transbot updated translations from Transifex

9b603b2

[MOV] stock_quant_manual_assign: make module uninstallable

23b259a

[FIX] remove en.po that was erroneously created by transbot

532f63f

[MIG] Rename manifest files

4a1e039

[9.0][MIG] stock_manual_assign: Migration to 9.0

52c1a97

* Fix uom issue * Convert move quantity in the default product uom to use the same uom as quant

[FIX] computation of remaining qty

73a5104

[FIX] test_flake8 [FIX] - use the already existing field product_qty - fix picking edition by warehouse user due to related none readonly field

Fix: avoid remove assigned lots on manual assignement

d25469b

[FIX] stock_quant_manual_assign: computed field is not the same

443783a

[CHG] stock_quant_manual_assign: Update copyright and author

b1ae830

[10.0][MIG] stock_quant_manual_assign: Migration to 10.0

1cbcf59

11.0-mig-stock_quant_manual_assign

3334b4c

[MIG] stock_quant_manual_assign: Migration to 11.0

2234a2e

cubells force-pushed the 11.0-mig-stock_quant_manual_assign branch from b3e83a8 to 2234a2e Compare November 16, 2018 16:42

fanha99 approved these changes Nov 17, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

[IMP] stock_quant_manual_assign:

ec5025d

* Better layout * Remove active_id dependency in some computed fields * Clean code * Refine constraint * Take into account if the current line is previously reserved before clicking on the button.

pedrobaeza force-pushed the 11.0-mig-stock_quant_manual_assign branch from 2d73dba to ec5025d Compare November 20, 2018 22:38

This comment has been minimized.

Sign in to view

rousseldenis approved these changes Nov 21, 2018

View reviewed changes

OCA-git-bot added the approved label Nov 21, 2018

OCA-git-bot added the ready to merge label Nov 21, 2018

pedrobaeza merged commit 4a3a551 into OCA:11.0 Nov 21, 2018

pedrobaeza deleted the 11.0-mig-stock_quant_manual_assign branch November 21, 2018 08:36

pedrobaeza mentioned this pull request Nov 21, 2018

Migration to version 11.0 #343

Closed

46 tasks

i-vyshnevska pushed a commit to camptocamp/stock-logistics-warehouse that referenced this pull request Apr 13, 2020

Merge pull request OCA#508 from meigallodixital/12.0-mig-stock_no_neg…

04bd1e4

…ative [12.0][MIG] Migration of stock_no_negative

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] stock_quant_manual_assign: Migration to 11.0 #508

[MIG] stock_quant_manual_assign: Migration to 11.0 #508

cubells commented Nov 12, 2018

cubells commented Nov 12, 2018 •

edited

Loading

fanha99 commented Nov 12, 2018

cubells commented Nov 12, 2018

pedrobaeza commented Nov 13, 2018 •

edited

Loading

LoisRForgeFlow left a comment

rousseldenis left a comment

pedrobaeza commented Nov 16, 2018

cubells commented Nov 16, 2018

fanha99 left a comment

LoisRForgeFlow commented Nov 19, 2018

This comment has been minimized.

This comment has been minimized.

pedrobaeza commented Nov 21, 2018

rousseldenis left a comment

OCA-git-bot commented Nov 21, 2018

[MIG] stock_quant_manual_assign: Migration to 11.0 #508

[MIG] stock_quant_manual_assign: Migration to 11.0 #508

Conversation

cubells commented Nov 12, 2018

cubells commented Nov 12, 2018 • edited Loading

fanha99 commented Nov 12, 2018

cubells commented Nov 12, 2018

pedrobaeza commented Nov 13, 2018 • edited Loading

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 16, 2018

cubells commented Nov 16, 2018

fanha99 left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Nov 19, 2018

This comment has been minimized.

This comment has been minimized.

pedrobaeza commented Nov 21, 2018

rousseldenis left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 21, 2018

cubells commented Nov 12, 2018 •

edited

Loading

pedrobaeza commented Nov 13, 2018 •

edited

Loading