Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] stock_move_location #535

Merged
merged 5 commits into from
Jan 30, 2019
Merged

[11.0][MIG] stock_move_location #535

merged 5 commits into from
Jan 30, 2019

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Jan 25, 2019

@sebalix sebalix mentioned this pull request Jan 25, 2019
Closed
4 tasks
@rousseldenis rousseldenis added this to the 11.0 milestone Jan 25, 2019
@pedrobaeza pedrobaeza mentioned this pull request Jan 25, 2019
Closed
46 tasks
simahawk
simahawk requested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor glitches

stock_move_location/models/stock_move.py Outdated Show resolved Hide resolved
stock_move_location/models/stock_move.py Outdated Show resolved Hide resolved
stock_move_location/readme/USAGE.rst Outdated Show resolved Hide resolved
stock_move_location/tests/test_move_location.py Outdated Show resolved Hide resolved
stock_move_location/wizard/stock_move_location.py Outdated Show resolved Hide resolved
stock_move_location/wizard/stock_move_location_line.py Outdated Show resolved Hide resolved
stock_move_location/wizard/stock_move_location_line.py Outdated Show resolved Hide resolved
@simahawk
Copy link
Contributor

build is red since _get_available_quantity gives you back a float and not a list

fclementic2c
fclementic2c approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@fclementic2c fclementic2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok

gurneyalex
gurneyalex approved these changes Jan 29, 2019
View reviewed changes
stock_move_location/i18n/stock_move_location.pot
@@ -0,0 +1,168 @@
# Translation of Odoo Server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PRs for new modules must not include a pot file these days as this is generated by weblate.

@sbidoul @pedrobaeza do you confirm?

(BTW maybe we should have an automated test for this)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.pot will be (re)generated by travis after merge. It does not harm if one is provided in the PR.

The only thing we try to avoid is PRs to existing modules that update .po, because that can generate merge conflicts with weblate.

@sebalix sebalix force-pushed the 11.0-mig-stock_move_location branch from f0d590c to 1093afe Compare January 29, 2019 08:44
@sebalix
Copy link
Contributor Author

sebalix commented Jan 29, 2019

Fixup commits squashed.

@sebalix sebalix force-pushed the 11.0-mig-stock_move_location branch from 1093afe to c9af30a Compare January 29, 2019 16:17
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis rousseldenis merged commit 74c2017 into OCA:11.0 Jan 30, 2019
@sebalix sebalix deleted the 11.0-mig-stock_move_location branch January 30, 2019 10:28
@sebalix
Copy link
Contributor Author

sebalix commented Jan 30, 2019

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tonow-c2c Tonow-c2c Tonow-c2c left review comments

@sbidoul sbidoul sbidoul left review comments

@simahawk simahawk simahawk approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@fclementic2c fclementic2c fclementic2c approved these changes

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
10 participants
@sebalix @simahawk @OCA-git-bot @sbidoul @gurneyalex @fclementic2c @rousseldenis @Tonow-c2c @kos94ok-3D @mathieuvatel