Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] hr_timesheet_sheet_attendance #488

Conversation

dsolanki-initos
Copy link
Contributor

@dsolanki-initos dsolanki-initos commented May 20, 2022

Test failed as depended module "hr_timesheet_sheet" is not merged in 15.0 branch and below the link of PR:

#484

@dsolanki-initos dsolanki-initos force-pushed the 15.0-mig-hr_timesheet_sheet_attendance branch from b336167 to bd83332 Compare May 20, 2022 07:13
Copy link
Contributor

@fshah-initos fshah-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this module locally it's working fine.
Code review and functional tests.
LGTM

@fuentes73
Copy link
Member

Hi @dsolanki-initos thanks for your work but you should keep the commit history
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

@dsolanki-initos
Copy link
Contributor Author

dsolanki-initos commented Jun 13, 2022

Hi @dsolanki-initos thanks for your work but you should keep the commit history https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Okay i will change regard it

@dsolanki-initos dsolanki-initos deleted the 15.0-mig-hr_timesheet_sheet_attendance branch July 7, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants