[MIG] hr_timesheet_sheet: Migration to 15.0 #484

dochse · 2022-04-22T13:27:40Z

No description provided.

* [10.0] hr_timesheet_sheet * [11.0][MIG] hr_timesheet_sheet * [REMOVE] hr_timesheet.sheet.account * [REMOVE] 'new' state * [ADD] Tests * [UPD] Adapt to multicompany * [ADD] Add more tests (include multicompany tests) * [FIX] project_task_stage_allow_timesheet: show error message only if task * [ADD] Migration scripts to v11

Currently translated at 98.9% (88 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/ja/

Currently translated at 100,0% (89 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/pt_BR/

…ay into this module, which adds a configuration to select the week start day.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

If you run tests on Sunday, test_4 was not prepared for it, as next day is Monday, which belongs to other week, and thus not included in same timesheet. With this, we cover that case, decreasing one day instead of adding it.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 61.5% (112 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Currently translated at 88.4% (161 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Currently translated at 94.5% (172 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Currently translated at 97.2% (177 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Currently translated at 98.3% (179 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/nl/

…voice_id field of account.analytic.line adds it). Tests currently fail without having sale_timesheet addon installed. TT35948

dsolanki-initos

Functionally test LGTM!

@dochse Can you please check failed checks?

fuentes73 · 2022-05-21T10:32:57Z

Hi @dochse can you fix the pre-commit error?

gaikaz

Mig. changes LGTM
Please check pre-commit

gaikaz · 2022-05-26T15:58:59Z

hr_timesheet_sheet/__manifest__.py

+ '/hr_timesheet_sheet/static/src/js/backend.js',
+ '/hr_timesheet_sheet/static/src/scss/backend.scss'


Might be an issue after all.

Suggested change

'/hr_timesheet_sheet/static/src/js/backend.js',

'/hr_timesheet_sheet/static/src/scss/backend.scss'

'hr_timesheet_sheet/static/src/js/backend.js',

'hr_timesheet_sheet/static/src/scss/backend.scss'

JuanyDForgeflow · 2022-06-20T23:48:31Z

@dochse are you going to continue with this?

dsolanki-initos · 2022-07-08T07:22:50Z

@dochse can you please fix the checked failed?

dsolanki-initos · 2022-07-15T09:21:26Z

@dochse can you please run pre-commit run -a command for fixing the GitHub checks

dsolanki-initos · 2022-07-15T09:25:38Z

@astirpe can you please review this PR?

CRogos · 2022-08-23T08:54:16Z

@dochse are you still working on this PR?
I've created a fork of this PR and implemented the feedback of @gaikaz and tried to fix all pre-commit checks.
But there are several warnings where the string format variables are not used in the translation. I assume the translations need to be adapted, but I am not capable of these languages.

hr_timesheet_sheet/i18n/id.po:439: [W7968(po-msgstr-variables), ] Translation string couldn't be parsed correctly using string%variables TypeError('not all arguments converted during string formatting')

What is the procedure to continue with the translation issue and if @dochse is not active anymore? Shall I create a second PR #516 ?

dochse · 2022-08-23T09:00:00Z

@dochse are you still working on this PR? I've created a fork of this PR and implemented the feedback of @gaikaz and tried to fix all pre-commit checks. But there are several warnings where the string format variables are not used in the translation. I assume the translations need to be adapted, but I am not capable of these languages.

hr_timesheet_sheet/i18n/id.po:439: [W7968(po-msgstr-variables), ] Translation string couldn't be parsed correctly using string%variables TypeError('not all arguments converted during string formatting')

What is the procedure to continue with the translation issue and if @dochse is not active anymore? Shall I create a second PR #516 ?

Im not actively working on it anymore, so you are free to do with this as you will

pedrobaeza · 2022-09-21T10:07:48Z

Supersede by #516

MiquelRForgeFlow and others added 30 commits April 22, 2022 13:15

[UPD] Update hr_timesheet_sheet.pot

15b9cf2

Translated using Weblate (Japanese)

90edc0d

Currently translated at 98.9% (88 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/ja/

[11.0][hr_timesheet_sheet]: allow to display more than 40 cells

e6f262f

hr_timesheet_sheet: add menu 'Timesheet Sheets to Approve'

44840b5

[UPD] Update hr_timesheet_sheet.pot

a544a22

hr_timesheet_sheet: pass selected project context to task creation

15fc1a9

[11.0][IMP] hr_timesheet_sheet: ease extensions (OCA#131)

bb0cf93

[UPD] Update hr_timesheet_sheet.pot

58974e1

Fix task domain and default project_id

fe94218

Bump version

cacc3c6

[IMP] hr_timesheet_sheet ux

088accb

Code review

a7cd73f

Update contributors list

ad92b39

[UPD] Update hr_timesheet_sheet.pot

aab3e5e

[FIX] hr_timesheet_sheet: "Refuse" button name (OCA#134)

3484a86

[UPD] Update hr_timesheet_sheet.pot

a955b0f

[11.0][IMP] hr_timesheet_sheet: merge hr_timesheet_sheet_week_start_d…

248656e

…ay into this module, which adds a configuration to select the week start day.

[UPD] Update hr_timesheet_sheet.pot

e1b43e6

restrict selection of projects to those that have 'allow_timsheets' set

ed4ff04

[MIG] hr_timesheet_sheet: Migration to 12.0

b8816df

Update translation files

465e31d

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[FIX] hr_timesheet_sheet: Don't fail tests on Sunday

041b90f

If you run tests on Sunday, test_4 was not prepared for it, as next day is Monday, which belongs to other week, and thus not included in same timesheet. With this, we cover that case, decreasing one day instead of adding it.

[IMP] hr_timesheet_sheet: more extendability & cleanup

6a3b099

[FIX] Fix related fields in hr_timesheet_sheet

63debc4

[FIX] hr_timesheet_sheet: who approves timesheets should be the manager

a32b76c

[FIX]hr_timesheet_sheet : fix singleton error in _compute_line_ids

5ff73ce

Update translation files

e4a3223

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[FIX] timesheet sheet lines inconsistency

26d632b

simonstromb and others added 16 commits April 22, 2022 13:15

Translated using Weblate (Swedish)

f98a32c

Currently translated at 61.5% (112 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Translated using Weblate (Swedish)

3216578

Currently translated at 88.4% (161 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Translated using Weblate (Swedish)

4037e88

Currently translated at 88.4% (161 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Translated using Weblate (Swedish)

81d35c0

Currently translated at 94.5% (172 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Translated using Weblate (Swedish)

7e3e70b

Currently translated at 97.2% (177 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/sv/

Translated using Weblate (Dutch)

440e3fd

Currently translated at 98.3% (179 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/nl/

Translated using Weblate (Dutch)

bdfc197

Currently translated at 98.3% (179 of 182 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet/nl/

Do not merge invoiced timesheet lines

a119700

Do not try to remove invoiced lines

7c448a7

hr_timesheet_sheet 14.0.1.0.3

f8bbb08

hr_timesheet_sheet 14.0.1.0.4

503a7e2

[IMP] update dotfiles [ci skip]

163aa4d

[FIX] hr_timesheet_sheet: Add sale_timesheet dependency (timesheet_in…

80eeb08

…voice_id field of account.analytic.line adds it). Tests currently fail without having sale_timesheet addon installed. TT35948

hr_timesheet_sheet 14.0.1.1.0

fc50f59

[IMP] hr_timesheet_sheet: black, isort, prettier

15bd663

[MIG] hr_timesheet_sheet: Migration to 15.0

601a6c9

dsolanki-initos mentioned this pull request May 20, 2022

[15.0][MIG] hr_timesheet_sheet_attendance #488

Closed

dsolanki-initos reviewed May 20, 2022

View reviewed changes

gaikaz approved these changes May 23, 2022

View reviewed changes

gaikaz reviewed May 26, 2022

View reviewed changes

CRogos mentioned this pull request Aug 23, 2022

[15.0][MIG] hr_timesheet_sheet #516

Merged

pedrobaeza closed this Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] hr_timesheet_sheet: Migration to 15.0 #484

[MIG] hr_timesheet_sheet: Migration to 15.0 #484

dochse commented Apr 22, 2022

dsolanki-initos left a comment

fuentes73 commented May 21, 2022

gaikaz left a comment

gaikaz May 26, 2022

JuanyDForgeflow commented Jun 20, 2022

dsolanki-initos commented Jul 8, 2022

dsolanki-initos commented Jul 15, 2022

dsolanki-initos commented Jul 15, 2022

CRogos commented Aug 23, 2022

dochse commented Aug 23, 2022

pedrobaeza commented Sep 21, 2022

		'/hr_timesheet_sheet/static/src/js/backend.js',
		'/hr_timesheet_sheet/static/src/scss/backend.scss'

[MIG] hr_timesheet_sheet: Migration to 15.0 #484

[MIG] hr_timesheet_sheet: Migration to 15.0 #484

Conversation

dochse commented Apr 22, 2022

dsolanki-initos left a comment

Choose a reason for hiding this comment

fuentes73 commented May 21, 2022

gaikaz left a comment

Choose a reason for hiding this comment

gaikaz May 26, 2022

Choose a reason for hiding this comment

JuanyDForgeflow commented Jun 20, 2022

dsolanki-initos commented Jul 8, 2022

dsolanki-initos commented Jul 15, 2022

dsolanki-initos commented Jul 15, 2022

CRogos commented Aug 23, 2022

dochse commented Aug 23, 2022

pedrobaeza commented Sep 21, 2022