[15.0][MIG] hr_timesheet_sheet #516

CRogos · 2022-08-23T06:29:56Z

Improvement of #484

any idea how to fix these warnings in pre-commit?
hr_timesheet_sheet/i18n/id.po:439: [W7968(po-msgstr-variables), ] Translation string couldn't be parsed correctly using string%variables TypeError('not all arguments converted during string formatting')

* [10.0] hr_timesheet_sheet * [11.0][MIG] hr_timesheet_sheet * [REMOVE] hr_timesheet.sheet.account * [REMOVE] 'new' state * [ADD] Tests * [UPD] Adapt to multicompany * [ADD] Add more tests (include multicompany tests) * [FIX] project_task_stage_allow_timesheet: show error message only if task * [ADD] Migration scripts to v11

Currently translated at 98.9% (88 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/ja/

Currently translated at 100,0% (89 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/pt_BR/

…ay into this module, which adds a configuration to select the week start day.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

If you run tests on Sunday, test_4 was not prepared for it, as next day is Monday, which belongs to other week, and thus not included in same timesheet. With this, we cover that case, decreasing one day instead of adding it.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

CRogos · 2022-08-23T12:20:53Z

@dsolanki-initos and @gaikaz could you review again?

gaikaz

Code review: LGTM

dsolanki-initos

Code review functional Test LGTM!
Below are a few points that need to be taken care of

Please use TransactionCase instead of SavepointCase in test-case
Please remove the commented code

CRogos · 2022-08-25T12:15:20Z

@dsolanki-initos thanks for you review and findings. I've changed to TransactionCase and removed the commented code from the tests.

CRogos · 2022-09-16T09:19:57Z

@alexey-pelykh do you have an advice how to continue here on the pre-commit issue?

houssine78 · 2022-09-18T18:38:22Z

hi @pedrobaeza do you have an idea of what could be this pre-commit issue ? thank you

pedrobaeza · 2022-09-18T21:50:04Z

Some translations are incorrect:

hr_timesheet_sheet/i18n/id.po:439: [W7968(po-msgstr-variables), ]  Translation string couldn't be parsed correctly using string%variables TypeError('not all arguments converted during string formatting')
(and more)

CRogos · 2022-09-19T08:36:08Z

They are already wrong at version 14.0 (and earlier)

Will all future pre-commit actions fail, after we've merged this? (until the translation of all languages is fixed)
I assume this check is new in pre-commit v15 and maybe should be removed until the translations have been cleaned?

pedrobaeza · 2022-09-19T08:39:51Z

No, this check is correct and must be kept. The solution is to fix the translations.

CRogos · 2022-09-19T08:49:10Z

After or before the PR was merged?
The module only occurs in Weblate, after the PR was merged, correct?
Waiting for all Translations could take infinite time ;) because of to many involved languages and deleting the keys might also not the right solution.

edit:
In some cases might deleting an option? @pedrobaeza you are the Spanish native ;-)

pedrobaeza · 2022-09-19T09:05:53Z

Youy have to fix it here in the migration.

CRogos · 2022-09-19T09:19:01Z

hmm.. sorry but I do not speak all these languages. How can I fix this?
I can replace the final "." by ": %s" but I am not sure if this is right in all cases... especially in Japanese, Arabic, etc.
I think this process has to be improved, or I missed some guide on this type of issue.

pedrobaeza · 2022-09-19T09:27:51Z

I think the problem is not the language, but incorrect syntax. You just need to fix such syntax. I think it's a missing %s somewhere, but check the indicated line.

CRogos · 2022-09-19T09:52:27Z

In this case, adding ": %s" might be right in most languages:

but this case is already more difficult:

oca-clabot · 2022-09-19T14:32:46Z

Hey @CRogos, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

root root@intertek-odoo15.lxd (no github login found)

Appreciation of efforts,
OCA CLAbot

CRogos · 2022-09-19T15:09:12Z

@pedrobaeza Thanks for your input and support.
I did my very best to translate everything and left it in a separate commit on purpose, so that it can easily be backported to v13/14, after it was approved, because the same translation issues are there also.

Is there anything I can do on the failed project test coverage? I mean more than 100% of the patch cannot be tested, correct?
By the way, the link to the CLA is not working, but the cause should be fixed.

pedrobaeza · 2022-09-21T10:08:06Z

/ocabot migration hr_timesheet_sheet
/ocabot merge nobump

OCA-git-bot · 2022-09-21T10:08:29Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-516-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-09-21T10:15:22Z

Congratulations, your PR was merged at c8b05d1. Thanks a lot for contributing to OCA. ❤️

MiquelRForgeFlow and others added 30 commits April 22, 2022 13:15

[UPD] Update hr_timesheet_sheet.pot

15b9cf2

Translated using Weblate (Japanese)

90edc0d

Currently translated at 98.9% (88 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/ja/

[11.0][hr_timesheet_sheet]: allow to display more than 40 cells

e6f262f

hr_timesheet_sheet: add menu 'Timesheet Sheets to Approve'

44840b5

[UPD] Update hr_timesheet_sheet.pot

a544a22

hr_timesheet_sheet: pass selected project context to task creation

15fc1a9

[11.0][IMP] hr_timesheet_sheet: ease extensions (#131)

bb0cf93

[UPD] Update hr_timesheet_sheet.pot

58974e1

Fix task domain and default project_id

fe94218

Bump version

cacc3c6

[IMP] hr_timesheet_sheet ux

088accb

Code review

a7cd73f

Update contributors list

ad92b39

[UPD] Update hr_timesheet_sheet.pot

aab3e5e

[FIX] hr_timesheet_sheet: "Refuse" button name (#134)

3484a86

[UPD] Update hr_timesheet_sheet.pot

a955b0f

[11.0][IMP] hr_timesheet_sheet: merge hr_timesheet_sheet_week_start_d…

248656e

…ay into this module, which adds a configuration to select the week start day.

[UPD] Update hr_timesheet_sheet.pot

e1b43e6

restrict selection of projects to those that have 'allow_timsheets' set

ed4ff04

[MIG] hr_timesheet_sheet: Migration to 12.0

b8816df

Update translation files

465e31d

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[FIX] hr_timesheet_sheet: Don't fail tests on Sunday

041b90f

If you run tests on Sunday, test_4 was not prepared for it, as next day is Monday, which belongs to other week, and thus not included in same timesheet. With this, we cover that case, decreasing one day instead of adding it.

[IMP] hr_timesheet_sheet: more extendability & cleanup

6a3b099

[FIX] Fix related fields in hr_timesheet_sheet

63debc4

[FIX] hr_timesheet_sheet: who approves timesheets should be the manager

a32b76c

[FIX]hr_timesheet_sheet : fix singleton error in _compute_line_ids

5ff73ce

Update translation files

e4a3223

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[FIX] timesheet sheet lines inconsistency

26d632b

CRogos marked this pull request as ready for review August 23, 2022 12:20

CRogos mentioned this pull request Aug 23, 2022

Migration to version 15.0 #465

Open

17 tasks

gaikaz approved these changes Aug 23, 2022

View reviewed changes

dsolanki-initos reviewed Aug 25, 2022

View reviewed changes

CRogos requested a review from dsolanki-initos August 26, 2022 06:25

CRogos and others added 3 commits September 19, 2022 17:00

[IMP] hr_timesheet_sheet: black, isort, prettier

4499850

[MIG] hr_timesheet_sheet: Migration to 15.0

a22d03c

Fix python-format translation issues.

42f4331

pedrobaeza added this to the 15.0 milestone Sep 21, 2022

OCA-git-bot added the bot is merging ⏳ label Sep 21, 2022

OCA-git-bot merged commit 21216ca into OCA:15.0 Sep 21, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] hr_timesheet_sheet #516

[15.0][MIG] hr_timesheet_sheet #516

CRogos commented Aug 23, 2022 •

edited

Loading

CRogos commented Aug 23, 2022

gaikaz left a comment

dsolanki-initos left a comment •

edited

Loading

CRogos commented Aug 25, 2022

CRogos commented Sep 16, 2022

houssine78 commented Sep 18, 2022

pedrobaeza commented Sep 18, 2022

CRogos commented Sep 19, 2022

pedrobaeza commented Sep 19, 2022

CRogos commented Sep 19, 2022 •

edited

Loading

pedrobaeza commented Sep 19, 2022

CRogos commented Sep 19, 2022

pedrobaeza commented Sep 19, 2022

CRogos commented Sep 19, 2022

oca-clabot commented Sep 19, 2022

CRogos commented Sep 19, 2022

pedrobaeza commented Sep 21, 2022

OCA-git-bot commented Sep 21, 2022

OCA-git-bot commented Sep 21, 2022

[15.0][MIG] hr_timesheet_sheet #516

[15.0][MIG] hr_timesheet_sheet #516

Conversation

CRogos commented Aug 23, 2022 • edited Loading

CRogos commented Aug 23, 2022

gaikaz left a comment

Choose a reason for hiding this comment

dsolanki-initos left a comment • edited Loading

Choose a reason for hiding this comment

CRogos commented Aug 25, 2022

CRogos commented Sep 16, 2022

houssine78 commented Sep 18, 2022

pedrobaeza commented Sep 18, 2022

CRogos commented Sep 19, 2022

pedrobaeza commented Sep 19, 2022

CRogos commented Sep 19, 2022 • edited Loading

pedrobaeza commented Sep 19, 2022

CRogos commented Sep 19, 2022

pedrobaeza commented Sep 19, 2022

CRogos commented Sep 19, 2022

oca-clabot commented Sep 19, 2022

CRogos commented Sep 19, 2022

pedrobaeza commented Sep 21, 2022

OCA-git-bot commented Sep 21, 2022

OCA-git-bot commented Sep 21, 2022

CRogos commented Aug 23, 2022 •

edited

Loading

dsolanki-initos left a comment •

edited

Loading

CRogos commented Sep 19, 2022 •

edited

Loading