[18.0][MIG] web_responsive: Migration to 18.0 #3037
Conversation
|
@lasley I wonder why I see this error:
despite the tests succeed in a clean new database locally. I searched for this field user_year_born in odoo CE but it is not there, and I don't know where it came from. |
|
The issue is inside web_pivot_computed_measure module tests. |
|
Hi, I opened another PR #3057, welcome you review it |
kobros-tech
force-pushed
the
18.0-mig-web_responsive
branch
3 times, most recently
from
ac1f548 to
daaafd6
Compare
|
I referred to you in another PR that is a dependency for this PR tests |
|
Please, note this pr #3069 |
| steps: () => [ | ||
| stepUtils.showAppsMenuItem(), | ||
| { | ||
| trigger: '.o_navbar_apps_menu"]', |
There was a problem hiding this comment.
dear @CarlosRoca13 if this file is not correct, the test will fail and we will see red alarm by oca boat.
I don't believe if the syntax is wrong or the registry is not for tests, are you a developer?
we use pre-commit in OCA and this command is reviewing the syntax, as long as it is not raising errors here, then the syntax is correct too!
@kobros-tech The original purpose of this code is to patch the original function of Odoo, not to add a new test.
Therefore, this code is not executed when pre-commit is run or when tests are executed. It is used in other modules when you import showAppsMenuItem.
If you review the expression .o_navbar_apps_menu"], it is syntactically incorrect. It should be:
| trigger: '.o_navbar_apps_menu"]', | |
| trigger: '.o_navbar_apps_menu', |
Note: The extension of this filename must be renamed to .esm.js.
Sorry if I wrote parentheses instead of brackets; I edited my comment.
There was a problem hiding this comment.
thanks for clarification :)
now for this file, I copied it from 17.0 to 18.0, maybe there was a change of it during migration in the original PR
please review and if there is any bug tell me.
kobros-tech
force-pushed
the
18.0-mig-web_responsive
branch
3 times, most recently
from
804cb3f to
786da5e
Compare
* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive
* Bump version * Change all openerp to odoo * Fix qunit suite injection * Remove jQuery require * Change to new selectors: * `oe_leftbar` to `o_sub_menu` * `oe_logo` to `o_sub_menu_logo` * `oe_footer` to `o_sub_menu_footer` * `oe_secondary_menus_container` to `o_sub_menu_content` * Add style to hide oe_footer instead of remove to not break `support_branding` * Add note in ReadMe explaining override of `support_branding` * Set top margin of app drawer title to 0 to fit v10 proportions * Fix notification badge positioning * Add o_web_client class to body to fix overlaps * Scroll control panel with page * Change navbar z-index to not be overlapped by buttons * Raise z-index on header to raise over buttons * Handle layered notifications via z-index * Remove `#` from navigation links HREF to prevent history littering
* Rebalance z-indexes to fix overlay issue while still providing notification support
* Bold titles for apps in the app-drawer * Remove z-index from Control Panel buttons, so it doesn't overlap the menu. * Better responsive menus * Move systray icons/menus out of the menu and up to the top bar. * Increase avatar size and visibility. * Other minor menu behavior fixes. * Changes to fit odoo variables * And a little margin adjust on navbar-right * Top menu always thick * Removed overflow:hidden!important from main.less * Local patch: prevent body overflow auto * Stop using `style=` on `<body>` * Fix jquery drawer in anticipation of: blivesta/drawer#36
On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens
Make image editing controls always available, instead of depending on resolution or hover.
Small makeup to make it look good in XS screens.
* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change
* Change accesskey for `edit` in form view back to `e` to fix OCA#587
Before this patch, there was an incompatibility between this addon and l10n_es_toponyms, caused by the lack of wrapping of the special address field that was being added. Now layout works as expected in that case. In any other case, it seems sensible to wrap inputs so no more weird overflows happen and less chances of needing horizontal scrolling happen.
* Initial commit * Initial commit
Add support to serve menu icon in image URL format rather than base64. It can take advantanges from browser caching and Nginx proxy. Signed-off-by: Fai <lamkafai1997@gmail.com>
In Odoo 17, the Class TourStepUtils was removed, and stepUtils is now an object instead of a class. When this module is installed, the tours stop working and throw the error:
Uncaught Error: Dependencies should be defined by an array: function (require) {.
This commit adapts the code to align with these changes, ensuring that tours work correctly.
kobros-tech
force-pushed
the
18.0-mig-web_responsive
branch
2 times, most recently
from
a83ca83 to
bc83a0a
Compare
kobros-tech
force-pushed
the
18.0-mig-web_responsive
branch
from
bc83a0a to
4324b3a
Compare
|
Wow wow wow |
|
I see that #3057 doesn't require to do anything in the tests on |
|
Testing the module in runboat, I detect that all the part that neutralizes the automatic preview seems to be not working (and consequently, the own sided preview). |
what is the value of this conversation if the old tests is not interfering the migration? even the other migration that you mentioned does not include all tests, but removed some of them. if you want to see the errors with the other PR ask the contributor to leave the tests as they are and you will see this same error. Even you can try it locally and catch the error. I seek to correct not to mock the correctness |
|
OK, just asking. I always try to touch the minimum the existing things. Please check my other comment that affects the functionality. |
we observed some errors in the UI we will fix, I don't know if they are the same but I am happy if you share them. |
|
I have already commented the problem. Is it not clear? |
I will check it and compare to the issues we found, give me some time. thanks for reviewing and helping me to improve the migration. |
nevermind, this seems complicated and worrying and shall see the value when all gaps get filled. Thanks for inquiry. |
Can you provide me with screenshots or log messages, we are fixing an error with the urls of search results |
kobros-tech
force-pushed
the
18.0-mig-web_responsive
branch
from
10b51cc to
3ef1bf3
Compare
|
Please include #3075 |
|
I will add merged commits to this PR, thanks |
Removed the optimisation of hiding the week number at a certain size for consistency with the responsive design of Odoo enterprise. It is a non-functional optimisation as it hides useful information that hardly takes up any space. It also causes incompatibilities in the design with extensions that do not take into account these specific changes. TT54811
|
Ping @pedrobaeza @carlos-lopez-tecnativa @pilarvargas-tecnativa any news guys |
| </xpath> | ||
| <xpath expr="//t[@t-set-slot='toggler']" position="replace"> | ||
| </xpath> --> | ||
| <!-- <xpath expr="//t[@t-set-slot='toggler']" position="replace"> |
There was a problem hiding this comment.
This is no longer necessary?
No description provided.