Remove deleted text regions from reading order, validate coords #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PAGE XML requires all elements referenced in the reading order to be actually present as a region. With this commit, deleted zones are removed from the reading order element which itself is reindexed afterwards. Fixes OCR-D#3
- ReadingOrder can be more than just an OrderedGroup list of RegionRefIndexed:
- OrderedGroup list of OrderedGroupIndexed
- OrderedGroup list of UnoderedGroupIndexed
- UnorderedGroup list of RegionRef
- UnorderedGroup list of OrderedGroup
- UnorderedGroup list of UnoderedGroup
- for any *GroupIndexed: same options as
the Group of the same name (recursive)
- so we need to query more members, and ask for their class
in order to query for the right members in turn; also,
we have to write back to the respective list with the
masked regions removed; and (only) for ordered groups,
we must re-index that list; finally, in the group case,
we have to call recursively (which moreover necessitates
separating this into a function)
wrznr
approved these changes
Nov 12, 2019
| LOG.info('Comparing regions "%s" and "%s"', regions[i].id, regions[j].id) | ||
| region_poly1 = Polygon(polygon_from_points(regions[i].get_Coords().points)) | ||
| region_poly2 = Polygon(polygon_from_points(regions[j].get_Coords().points)) | ||
| mark_for_deletion = list() |
There was a problem hiding this comment.
I do not understand why you move from set to list.
There was a problem hiding this comment.
I removed the comment on that in the last commit: Because generateDS does not make element classes hashable.
| if not isinstance(elem, (RegionRefType, RegionRefIndexedType)): | ||
| _plausibilize_group(regions, elem, mark_for_deletion) | ||
| for region in regions: | ||
| if (region in mark_for_deletion and |
There was a problem hiding this comment.
This is in O(1) with set but in O(n) with list.
There was a problem hiding this comment.
Absolutely. It's a shame all our processors must be formulated so clumsily just because generateDS output is suboptimal. It will be hard to change that even after we start injecting custom code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplant #4, fix #3.
@kba, The new validation behaviour could also be interesting for
ocrd_validatorsin core.