Simplify binary modules types #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapashcanon
force-pushed
the
simplifybinary
branch
2 times, most recently
from
36246d0 to
979e570
Compare
zapashcanon
commented
Aug 20, 2024
zapashcanon
force-pushed
the
simplifybinary
branch
3 times, most recently
from
b8cd082 to
5390467
Compare
zapashcanon
force-pushed
the
simplifybinary
branch
from
5390467 to
102d03a
Compare
zapashcanon
force-pushed
the
simplifybinary
branch
from
102d03a to
6d2ed55
Compare
|
This should be correct now. There was some subtle bug about extra This makes the code shorter, easier to understand, more efficient and fix some bugs. Thus I'm going to merge once CI is happy. :) @Laplace-Demon, could you confirm it it also fixes the issue you are encountering in your other PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #352