Skip to content

Fix Enum Flag Logic to Correctly Match Specific Flags#1442

Merged
WanjohiSammy merged 1 commit intomainfrom
fix/multiple-flags-set
Mar 17, 2025
Merged

Fix Enum Flag Logic to Correctly Match Specific Flags#1442
WanjohiSammy merged 1 commit intomainfrom
fix/multiple-flags-set

Conversation

@WanjohiSammy
Copy link
Member

Description

This PR addresses an issue with the Flags enum logic where the bitwise AND operation (graphValue & flagValue) != 0 incorrectly matches combined flags when only specific flags are intended.

The current logic (graphValue & flagValue) != 0 checks if any of the bits in flagValue are set. While this works for simple flag checks, it fails when combined flags are involved. For example, if Admin is a combination of Read, Write, and Execute, checking for Read and Write using the current logic will also match Admin, which is not the intended behavior.

[Flags]
 public enum AccessLevel
 {
     None = 0,
     Read = 1,
     Write = 2,
     Execute = 4,
     Admin = 7 // Read | Write | Execute
 }

To resolve this issue, the logic has been updated to (graphValue & flagValue) == flagValue, which ensures that only the specified flags are matched correctly. This change prevents combined flags from being incorrectly matched when checking for specific flags.

@WanjohiSammy WanjohiSammy merged commit f44f6e0 into main Mar 17, 2025
2 checks passed
@WanjohiSammy WanjohiSammy deleted the fix/multiple-flags-set branch March 17, 2025 20:34
ArnaudB88 added a commit to ArnaudB88/OData2Linq that referenced this pull request Jul 16, 2025
* Migrate to ESRP v5 (OData#1421)

* Migrate to ESRP v5

* Replace raw resource identifiers with variables

* Fix typo in KV variable

* Add Obsolete attribute to EdmDeltaResourceObject and
EdmDeltaComplexObject type

* Fix regression causing navigation properties to be auto-expanded in typeless scenarios (OData#1424)

* Bump version to 9.2.1 (OData#1437)

* Fix an issue where multiple flags are set and ensure correct deserialization (OData#1442)

* Fixes OData#1455 Add ISearchQueryValidator (OData#1456)

* Restructure AggregationBinder and ComputeBinder for extensibility (port OData#1378) (OData#1457)

* Bump version to 9.3.0 (OData#1464)

* Fix the typo of generaticType

* Fixes OData#580 Change PageResult<T> property names on serialization

* Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand (OData#1474)

* Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand

* Address the comments.

* Ensuring Url safe string key values. Aligning with ODL Client. Fixes OData#1390. (OData#1396)

* CA2254 fixes possible formatting errors

* bump to release version 9.3.1

* Enable minimal API OData (OData#1469)

* Enable minimal API OData

* Simple exclude the metadata and servicedocument reault out from the filter.

* add content-type into response header

* Enable Delta<T> as parameter

* update the comments and public api

* Bump to version 9.4.0 preview

* Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....' (OData#1486)

* Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....'

* Bump version to 9.3.2

* Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization (OData#1488)

* Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization
minimalApi

Enable ODataActionParameter and ODataUntypedActionParameter binding

* Address the comment to move the error messge to Resources

* Resolve the issue with IAsyncEnumerable (OData#1467)

* Resolve the issue with IAsyncEnumerable

* Resolve FormatException by escaping curly brackets and add tests for SRResources (OData#1475)

* Fix vulnerable dependencies in newtonsoft.json (OData#1489)

* Fix vulnerable dependencies
* Replace Microsoft.CodeAnalysis.FxCopAnalyzers with Microsoft.CodeAnalysis.NetAnalyzers

* Fixes OData#1494: Enable DeltaSet<T> for minimal API parameter binding
ArnaudB88 added a commit to ArnaudB88/OData2Linq that referenced this pull request Jul 16, 2025
* bump version

* Update reference to ASP.NET Core OData v9.3.2 (#7)

* Migrate to ESRP v5 (OData#1421)

* Migrate to ESRP v5

* Replace raw resource identifiers with variables

* Fix typo in KV variable

* Add Obsolete attribute to EdmDeltaResourceObject and
EdmDeltaComplexObject type

* Fix regression causing navigation properties to be auto-expanded in typeless scenarios (OData#1424)

* Bump version to 9.2.1 (OData#1437)

* Fix an issue where multiple flags are set and ensure correct deserialization (OData#1442)

* Fixes OData#1455 Add ISearchQueryValidator (OData#1456)

* Restructure AggregationBinder and ComputeBinder for extensibility (port OData#1378) (OData#1457)

* Bump version to 9.3.0 (OData#1464)

* Fix the typo of generaticType

* Fixes OData#580 Change PageResult<T> property names on serialization

* Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand (OData#1474)

* Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand

* Address the comments.

* Ensuring Url safe string key values. Aligning with ODL Client. Fixes OData#1390. (OData#1396)

* CA2254 fixes possible formatting errors

* bump to release version 9.3.1

* Enable minimal API OData (OData#1469)

* Enable minimal API OData

* Simple exclude the metadata and servicedocument reault out from the filter.

* add content-type into response header

* Enable Delta<T> as parameter

* update the comments and public api

* Bump to version 9.4.0 preview

* Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....' (OData#1486)

* Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....'

* Bump version to 9.3.2

* Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization (OData#1488)

* Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization
minimalApi

Enable ODataActionParameter and ODataUntypedActionParameter binding

* Address the comment to move the error messge to Resources

* Resolve the issue with IAsyncEnumerable (OData#1467)

* Resolve the issue with IAsyncEnumerable

* Resolve FormatException by escaping curly brackets and add tests for SRResources (OData#1475)

* Fix vulnerable dependencies in newtonsoft.json (OData#1489)

* Fix vulnerable dependencies
* Replace Microsoft.CodeAnalysis.FxCopAnalyzers with Microsoft.CodeAnalysis.NetAnalyzers

* Fixes OData#1494: Enable DeltaSet<T> for minimal API parameter binding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants