tests/luaxform: Lua transform tests #2090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
jufajardini
requested changes
Oct 29, 2024
There was a problem hiding this comment.
I think that maybe during rebasing there was a mishap with this commit: 8003c9f
:P
jufajardini
reviewed
Oct 29, 2024
| pcap: ../lua-transform-01/test.pcap | ||
|
|
||
| checks: | ||
|
|
There was a problem hiding this comment.
maybe nit, but why not have a check for the alert, here, too?
Comment on lines
+10
to
+16
| checks: | ||
| - filter: | ||
| count: 0 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 | ||
| http.url: /exec_post.php |
There was a problem hiding this comment.
won't there be a warning or error here that we could also check for?
To complement bug-7241 tests.
This commit adds tests for new Lua transform - Basic transform operation - Ensure non-existent Lua scripts are detected - Ensure Lua scripts without transform functions are detected - Ensure Lua scripts properly receive optional transform arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2044
This commit adds tests for new Lua transform
luaxformTicket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/2290
Suricata PR: OISF/suricata#11930