-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform: luaxform transform script #12247
Conversation
This commit makes the detection engine thread context available for transforms to use. The Lua transform requires this value. Issue: 2290
Issue: 2290 This commit extends the hash table logic with an alternate free function that provides the detection engine context. Users that wish to use the next functionality must use the HashListTableInitWithCtx function when initializing the hash table. Using this interface will result in the hash table "free with context" function (new) being used instead.
Issue: 2290 Defer freeing the keyword hash table until the engine context has been freed. This eliminates a double-free from occurring. For the unittests ONLY, clear the keyword_hash to prevent a double free attempt.
Issue: 2290 This commit adds the source files for the new transform -- luaxform.
Issue: 2290
git grep -A 1 -w InspectionBufferSetup shows numbers cases of the pattern: - InspectionBufferSetup - InspectionBufferApplyTransforms Refactor the implementations of those functions into InspectionBufferSetupAndApplyTransforms to reduce function call count. Issuer: 2290
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12247 +/- ##
==========================================
+ Coverage 83.18% 83.21% +0.03%
==========================================
Files 912 914 +2
Lines 257174 257389 +215
==========================================
+ Hits 213930 214192 +262
+ Misses 43244 43197 -47
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 23724 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my end, I think that the section's organization is the only thing missing, at this point. Thanks for tackling the feedback so far.
As I can't edit regions that were not changed, the full diff would look like this (I checked the result with make html
and it looks correct, but ofc do adjust if the hierarchy looks off or should be different):
diff --git a/doc/userguide/rules/lua-detection.rst b/doc/userguide/rules/lua-detection.rst
index 2a8ed241e..4dfeeaf00 100644
--- a/doc/userguide/rules/lua-detection.rst
+++ b/doc/userguide/rules/lua-detection.rst
@@ -29,7 +29,7 @@ A Lua rule script has 2 required functions, an ``init`` function and
Additionally, the script will run in a limited sandbox by default.
Init function
--------------
+^^^^^^^^^^^^^
.. code-block:: lua
@@ -70,7 +70,7 @@ All the HTTP buffers have a limitation: only one can be inspected by a
script at a time.
Match function
---------------
+^^^^^^^^^^^^^^
.. code-block:: lua
@@ -112,12 +112,12 @@ Entire script:
return 0
Lua Transform: ``luaxform``
-^^^^^^^^^^^^^^^^^^^^^^^^^^^
+---------------------------
More details in :ref:`lua-transform`.
Lua Sandbox and Available functions
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+-----------------------------------
Continued in #12251 |
Continuation of #12246
Add the
luaxform
transform that uses a Lua script to receive and transform a sticky buffer.Lua transforms receive arguments
Arguments are passed to the Lua script as they appear in the rule:
When the transform is invoked, 3 additional arguments are passed (arg count will be 3)
bytes 4
offset 13
hash sha256
The Lua script is responsible for parsing and using the arguments and returning a tuple:
output-buffer, output-buffer-byte-count
I used this Lua script:
Example rule using the Lua script:
Link to ticket: https://redmine.openinfosecfoundation.org/issues/2290
Describe changes:
Updates
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCH
variable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2090
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=