Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No notification when edit pin or how-to #1008

Closed
davehakkens opened this issue Aug 21, 2020 · 0 comments · Fixed by #1009
Closed

No notification when edit pin or how-to #1008

davehakkens opened this issue Aug 21, 2020 · 0 comments · Fixed by #1009
Assignees
@alromh87

Comments

@davehakkens
Copy link
Contributor

davehakkens commented Aug 21, 2020 •
edited
Loading

Component infos

Description

We receive to many notifications of all the edits people make to their map pin and how-to's.
This also gives messy notifications in Discord. So:

  1. We only verify pins and how-to’s in the beginning. Not edits
  2. Edits for pins and how-to’s are automatically approved.
  3. No notification in Slack or Discord for an edit.

Bounty level #1
@alromh87 alromh87 mentioned this issue Aug 22, 2020
Merged
3 tasks
alromh87 added a commit to alromh87/community-platform that referenced this issue Aug 27, 2020
@alromh87
Fixes ONEARMY#1008
5eb443e 
There was a mistake in 252df32, firebase syntax was used instead of firestore.

Avoid notification when user edits pin or howto and it was previuosly accepted.

Notification will be triggered if user reverts to draft and then try to publish after being accepted.

Note: will trigger disscord message, maybe we could add field in DB to know it has been accepted before.... Would it brake frontend??
@alromh87 alromh87 mentioned this issue Aug 27, 2020
Merged
6 tasks
BenGamma added a commit that referenced this issue Sep 9, 2020
@BenGamma
Merge pull request #1021 from alromh87/b1008
16e2fbb 
Avoid notification when user edits pin or howto and it was previuosly accepted. #1008
@BenGamma BenGamma mentioned this issue Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alromh87 alromh87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid notification when user edits pin or howto alromh87/community-platform
2 participants
@alromh87 @davehakkens