Avoid notification when user edits pin or howto and it was previuosly accepted. #1008 #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in 252df32, firebase syntax was used instead of firestore. Avoid notification when user edits pin or howto and it was previuosly accepted. Notification will be triggered if user reverts to draft and then try to publish after being accepted. Note: will trigger disscord message, maybe we could add field in DB to know it has been accepted before.... Would it brake frontend??
alromh87
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Added db field to avoid triggering discord message after user edit prevously accepted pin/howto.
BenGamma
approved these changes
Sep 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in 252df32, firebase syntax was used instead of firestore.
Avoid notification when user edits pin or howto and it was previuosly accepted.
Notification will be triggered if user reverts to draft and then try to publish after being accepted.
Note: will trigger disscord message, maybe we could add field in DB to know it has been accepted before.... Would it brake frontend??
PR Type
PR Checklist
masterbranch mergedDescription
What this PR does
Git Issues
_Closes #1008
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes