Fix #974 Extra infromation on Profile #1031
Conversation
Bring latest changes to branch 974 Conflicts: src/pages/User/content/UserPage/UserPage.tsx
Shows information on user profile - [x] Location with link to map pin - [x] Accepted HowTos - [x] Accepted Events User stats are computed via firebase function triggered by database changes
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This profiles show different validations:
As requested in #974 |
There was a problem hiding this comment.
If I understand well the counts for how-to and events will be triggered on creation or on edit right ?
So to have this information available we'll need to modify all the existing howtos and events ? I'm trying to understand how we are going to proceed for migration.
Other than that see my comments for small changes.
Thanks for the work !
| @@ -8,6 +8,7 @@ interface IProps { | |||
| width?: string | |||
| ticked?: boolean | |||
| contain?: boolean | |||
| mr?: number | |||
There was a problem hiding this comment.
In that case it will be better to extend the props from rebass BoxProps directly, but I don't think you need to add it here, and I don't see it used anywhere else anyway ?
There was a problem hiding this comment.
It was needed to be able to change the margin of the internal box, which had it fixed to 4, now it will default to 4(avoid braking other displays), but can be overwiten when usng component, used to make howto event display in one line
Maybe your right, but i dont know how to do that 😓
|
The user stats will be stored under as a map under user collection, update of this values will be triggered by how-to/events update using firestore functions. Functions are at functions/src/Integrations/user-stats.ts , I gess I'm missing some config since they where not deployed. I already have script for the initial calculation and update of user.stats for migration, this would be executed just once, after that updates will be calculated based on individual howto/event data, for faster execution |
As far as I know they will need to be deployed on firebase once merged with master.
Ok nice, can I see this script ? |
|
I added a commit so I had to create a new branch and new PR, discussion moved to #1040 |
|
Migration script: |
Shows information on user profile
User stats are computed via firebase function triggered by database changes