-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/974 extra infos profile #1040
Conversation
Bring latest changes to branch 974 Conflicts: src/pages/User/content/UserPage/UserPage.tsx
Shows information on user profile - [x] Location with link to map pin - [x] Accepted HowTos - [x] Accepted Events User stats are computed via firebase function triggered by database changes
…t in user stats box
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This is the script Im preparing form migration, I have been testing it from Cloud Console since I have no permissions to execute https endpoint It also contains code for migration for 972 Update all flags in HowTos
|
Now they will calculate stats if user has no previous information
Updated the count functions to handle no previously calculated data:
|
This makes the PR ready to merge no need to execute the migration script |
Thanks for updating the script ! |
Glad to help The files in PR are targeted only to this PR, the script posted here is only for reference and not included in PR. |
Yes I got that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see a larger feature like this coming in, nice work on front and back end. I've given a few inline comments, but would be happy to still merge and review after we've tested a little on the dev site.
I'm guessing we might also want a one-off function that could be called from the API to populate the db with all the existing howtos/events.
Could this be merged? |
Closes #974
Based on work in #1031