Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #964 "Create How-to" button for not-logged in #1035

Closed

Conversation

alromh87
Copy link
Collaborator

@alromh87 alromh87 commented Sep 6, 2020

When not logged in create how to button will redirect to create account

Updated with changes from master, sends no error on build

@cypress
Copy link

cypress bot commented Sep 6, 2020



Test summary

60 0 0 0


Run details

Project onearmy-community-platform
Status Passed
Commit 9b22846 ℹ️
Started Sep 6, 2020 4:25 PM
Ended Sep 6, 2020 4:32 PM
Duration 07:46 💡
OS Linux Ubuntu Linux - 16.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BenGamma
Copy link
Contributor

With #1036 and this PR did you had anything to add or was is just to update with master ?

@alromh87
Copy link
Collaborator Author

Just update to master, no conflicts

Feature mentions adding the same behavior for pin and howto wich is not imlemented

@alromh87
Copy link
Collaborator Author

Just update to master, no conflicts

Feature mentions adding the same behavior for pin and howto wich is not implemented

@BenGamma
Copy link
Contributor

Feature mentions adding the same behavior for pin and howto wich is not implemented

Can you be a bit more precise here ? How is the feature linked to pin ?

@davehakkens
Copy link
Contributor

That the same button should be there for "map" and "events"
#964

@alromh87
Copy link
Collaborator Author

If I understand correctly this, the button to add event and pin
Captura de pantalla de 2020-09-14 16-04-13

Captura de pantalla de 2020-09-14 16-04-21

@davehakkens
Copy link
Contributor

correct

@BenGamma
Copy link
Contributor

Ah yes, I pushed some changes and reopen #987. I still need to add the Map pin button.

Will close this one.
Now Alejandro have rights to create PR directly from the repo so hopefully there will be no more jump for PR to PR in the futur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants