Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:display create button for non signed-in user in how-to list #987

Merged
merged 9 commits into from
Sep 30, 2020

Conversation

BenGamma
Copy link
Contributor

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)
  • - Passes Tests

Description

I removed the <AuthWrapper> to wrap the create button and instead check if a user is present in the store to accordingly redirect to corresponding url.

Git Issues

Closes #964

@BenGamma BenGamma requested a review from chrismclarke June 19, 2020 17:50
@cypress
Copy link

cypress bot commented Jun 19, 2020



Test summary

53 5 0 2


Run details

Project onearmy-community-platform
Status Failed
Commit 76e9f6a ℹ️
Started Sep 30, 2020 1:45 PM
Ended Sep 30, 2020 1:51 PM
Duration 05:54 💡
OS Linux Ubuntu Linux - 16.04
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

Run group: 2x-chrome (Linux, Chrome )
cypress/integration/events.spec.ts Failed
1 [Events] > [List events] > [By Everyone]
2 [Events] > [List events] > [By Authenticated]
3 [Events] > [Create an event] > [By Authenticated]
Run group: 2x-firefox (Linux, Firefox )
cypress/integration/events.spec.ts Failed
1 [Events] > [List events] > [By Everyone]
2 [Events] > [List events] > [By Authenticated]

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BenGamma
Copy link
Contributor Author

Hey @chrismclarke I'm running into weird test failures since the last upgrade. They doesn't seems to be linked with the changes I made in this PR. What suprises me is that they passed on master 🤔 any hint on this one ?

Copy link
Collaborator

@alromh87 alromh87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tried both PR version from jun and incorporating changes from master, it merged with no conflicts and workes as expected.

@BenGamma
Copy link
Contributor Author

Closing since moved to #1035

@BenGamma BenGamma closed this Sep 14, 2020
@BenGamma BenGamma merged commit c853fc8 into master Sep 30, 2020
@BenGamma BenGamma deleted the feat/964_create-button-for-non-logged-user branch September 30, 2020 13:50
This was referenced Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create How-to" button for not-logged in
2 participants