-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:display create button for non signed-in user in how-to list #987
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Hey @chrismclarke I'm running into weird test failures since the last upgrade. They doesn't seems to be linked with the changes I made in this PR. What suprises me is that they passed on master 🤔 any hint on this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tried both PR version from jun and incorporating changes from master, it merged with no conflicts and workes as expected.
Closing since moved to #1035 |
PR Type
PR Checklist
master
branch mergedDescription
I removed the
<AuthWrapper>
to wrap the create button and instead check if a user is present in the store to accordingly redirect to corresponding url.Git Issues
Closes #964